Skip to content

Conversation

@mebbaid
Copy link
Contributor

@mebbaid mebbaid commented Sep 16, 2024

The pedals only provide 3 axis values and no buttons. I replicate the results obtained with TT robots on the main WalkingJoypadModule. In essence;

  • To command the linear velocity, one needs to press both pedals equally.
  • To command lateral Velocity, one needs to press one more than the other with the pressed one corresponding to the desired direction ⚠️ this also allows diagonal commands!
  • To command the angular velocity one needs to push one pedals forward with the pushed pedal corresponding to the desired rotation direction

⚠️ I need to test with the robot and also to check if I didn't break the other options (gamepad and keypoard). In theory It should be ok.

@mebbaid mebbaid marked this pull request as ready for review September 17, 2024 10:14
@mebbaid
Copy link
Contributor Author

mebbaid commented Sep 17, 2024

The modifications were tested on the robot, and the PR is ready for review.

Co-authored-by: Stefano Dafarra <stefano.dafarra@gmail.com>
Copy link
Collaborator

@S-Dafarra S-Dafarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for iterating @mebbaid. One final comment. Then we can just try once again on the robot and go forward!

Co-authored-by: Stefano Dafarra <stefano.dafarra@gmail.com>
@mebbaid
Copy link
Contributor Author

mebbaid commented Sep 18, 2024

One final comment. Then we can just try once again on the robot and go forward!

This was done in 936cdbe and the modifications were tested both for pedals and keyboard.

@GiulioRomualdi GiulioRomualdi changed the title add type config option and possibility to use pedals Add type config option and possibility to use pedals Sep 19, 2024
@GiulioRomualdi
Copy link
Collaborator

We can test it on the robot today

@GiulioRomualdi GiulioRomualdi merged commit 05af78f into gbionics:master Sep 19, 2024
@mebbaid mebbaid deleted the feature/pedals_joypad branch September 19, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants