Semifinal testing #111
Merged
Semifinal testing #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S-Dafarra
approved these changes
May 6, 2022
Collaborator
|
@GiulioRomualdi I think we can merge this |
Collaborator
Author
|
I don't know if it makes sense to merge the code as it is since it contains the ellipsoid active and some initial joint configuration for the robot that are usefull only for xprize |
Collaborator
In my opinion, yes. In this way, this branch would be part of the history. Then, we will edit them back in future PRs. |
S-Dafarra
force-pushed
the
semifinal-testing
branch
from
a5c0e30 to
74cc188
Compare
Collaborator
|
I have opened #114 with the changes to the parameters that revert this PR. Merging this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.