Fix install.sh to not include compliation commands in macOS release zip

[Rangi42]

The install.sh in rgbds-macos.zip for v1.0.2 and v1.0.3 has the c++ compile commands before the install commands.

[ISSOtm]

Hmm, here are some thoughts...

• We do not get to see the contents of install.sh in CI as it gets generated: should we tee -a them instead?
• Avoiding the problem in the future means making the target more robust, not just changing our release script right now. For example, we could add a ${MAKE} -s -t all (--touch is more explicit, but not compatible with BSD Make) to ensure that the target's prereq is always satisfied. Downside: this has a side-effect (touching the binaries). ${MAKE} -n install -W rgbasm -W rgblink -W rgbfix -W rgbgfx avoids the side effect, but requires explicitly listing the binaries and is not compatible with BSD Make.

[Rangi42]

Looks like this is only an issue for the macOS zip. The Windows zips have their own subdirectory issue #2044, but correct install.sh contents. The Linux tar.gz contains a flat hierarchy of files and a correct install.sh.

I've manually updated the rgbds-macos.zip files in the v1.0.2 and v1.0.3 releases.

[Rangi42]

We could add a ${MAKE} -s -t all (--touch is more explicit, but not compatible with BSD Make) to ensure that the target's prereq is always satisfied. Downside: this has a side-effect (touching the binaries).

Passing -t all also has the side effect of not even printing the install commands.

make install.sh with -d, without -t all:

Considering target file `install'.
 File `install' does not exist.
  Considering target file `all'.
   File `all' does not exist.
    ...
   Finished prerequisites of target file `all'.
  Must remake target `all'.
  Successfully remade target file `all'.
 Finished prerequisites of target file `install'.
Must remake target `install'.
install -d /usr/local/bin/ /usr/local/share/man/man1/ /usr/local/share/man/man5/ /usr/local/share/man/man7/
install -s -m 755 rgbasm /usr/local/bin/rgbasm
install -s -m 755 rgblink /usr/local/bin/rgblink
install -s -m 755 rgbfix /usr/local/bin/rgbfix
install -s -m 755 rgbgfx /usr/local/bin/rgbgfx
install -m 644 rgbasm.1 rgblink.1 rgbfix.1 rgbgfx.1 /usr/local/share/man/man1/
install -m 644 rgbds.5 rgbasm.5 rgbasm-old.5 rgblink.5 /usr/local/share/man/man5/
install -m 644 rgbds.7 gbz80.7 /usr/local/share/man/man7/
Successfully remade target file `install'.

make install.sh with -d, and with -t all:

Considering target file `all'.
 File `all' does not exist.
  ...
 Finished prerequisites of target file `all'.
Must remake target `all'.
Successfully remade target file `all'.
Considering target file `install'.
 File `install' does not exist.
  Pruning file `all'.
 Finished prerequisites of target file `install'.
Must remake target `install'.
Successfully remade target file `install'.

Both of these were run after make already created the binaries.

[ISSOtm]

...do we not mark those targets as .PHONY?!? O_o

[Rangi42]

${MAKE} -n install -W rgbasm -W rgblink -W rgbfix -W rgbgfx avoids the side effect, but requires explicitly listing the binaries and is not compatible with BSD Make.

This works, and since FreeBSD now installs gmake anyway for testing, we may as well start using a GNUMakefile. (Probably there are more GNU features we could take advantage of?)

[Rangi42]

...do we not mark those targets as .PHONY?!? O_o

We do:

.PHONY: all clean install develop debug profile coverage format tidy iwyu wine-shim dist

The -debug output refers to them as "files" anyway.

[ISSOtm]

OK, well, we have one big .PHONY line at the top, and IMO that's bad style (this is a good example why). I would advocate for refactoring that into a .PHONY: all line after each target (either before its deps line or after its command list).

[Rangi42]

I see no connection between our .PHONY declaration and this; you'll have to explain. Unless I've missed something, every non-file phone target we have is correctly declared as .PHONY, and every real file target we can create (including install.sh) is not.