Border uses palettes 4-6 only #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zlago called me out on my nonsense in #graphics on gbdev Discord. SGB firmware in Mesen-S updates palette 7 during menu navigation and fades palettes 4, 5, and 6 during border updates. This means a border cannot safely use palette 7.
avivace
requested changes
Oct 8, 2022
Co-authored-by: Antonio Vivace <avivace4@gmail.com>
ISSOtm
requested changes
Oct 8, 2022
Not hard-wrapping at a column count makes later edits easier to diff. Co-authored-by: Eldred Habert <eldredhabert0@gmail.com>
avivace
approved these changes
Oct 8, 2022
ISSOtm
requested changes
Oct 8, 2022
Co-authored-by: Eldred Habert <eldredhabert0@gmail.com>
ISSOtm
approved these changes
Oct 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zlago called me out on my nonsense in #graphics on gbdev Discord. SGB firmware in Mesen-S updates palette 7 during menu navigation and fades palettes 4, 5, and 6 during border updates. This means a border cannot safely use palette 7.