Danaj/unsafe decoding #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this PR is still valid. The example shown in issue 14 still goes into an infinite loop with 0.27, but does not with this change. This bug is hit by Convert::PEM's test suite, making a number of crypto modules dodgy to install. |
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jun 28, 2020
- EAPI7 - Remove empty/unused variable assignments - Add patch submitted to upstream repo to remedy CVE-2013-7488 Bug: https://bugs.gentoo.org/716680 Bug: gbarr/perl-Convert-ASN1#15 Bug: gbarr/perl-Convert-ASN1#14 Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1821879 Package-Manager: Portage-2.3.100, Repoman-2.3.22 Signed-off-by: Kent Fredric <kentnl@gentoo.org>
NeddySeagoon
pushed a commit
to NeddySeagoon/gentoo-arm64
that referenced
this pull request
Jun 29, 2020
- EAPI7 - Remove empty/unused variable assignments - Add patch submitted to upstream repo to remedy CVE-2013-7488 Bug: https://bugs.gentoo.org/716680 Bug: gbarr/perl-Convert-ASN1#15 Bug: gbarr/perl-Convert-ASN1#14 Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1821879 Package-Manager: Portage-2.3.100, Repoman-2.3.22 Signed-off-by: Kent Fredric <kentnl@gentoo.org>
timlegge
added a commit
to timlegge/perl-Convert-ASN1
that referenced
this pull request
May 21, 2021
From ce148a2 Mon Sep 17 00:00:00 2001 From: Dana Jacobsen <dana@acm.org> Date: Tue, 29 Oct 2013 08:37:48 -0700 Subject: [PATCH 1/2] Fix unsafe decoding in indef case From 8125d99 Mon Sep 17 00:00:00 2001 From: Dana Jacobsen <dana@acm.org> Date: Tue, 29 Oct 2013 08:53:09 -0700 Subject: [PATCH 2/2] Add second part of position check
timlegge
added a commit
to timlegge/perl-Convert-ASN1
that referenced
this pull request
May 21, 2021
From ce148a2 Mon Sep 17 00:00:00 2001 From: Dana Jacobsen <dana@acm.org> Date: Tue, 29 Oct 2013 08:37:48 -0700 Subject: [PATCH 1/2] Fix unsafe decoding in indef case From 8125d99 Mon Sep 17 00:00:00 2001 From: Dana Jacobsen <dana@acm.org> Date: Tue, 29 Oct 2013 08:53:09 -0700 Subject: [PATCH 2/2] Add second part of position check
timlegge
added a commit
to timlegge/perl-Convert-ASN1
that referenced
this pull request
May 21, 2021
From ce148a2 Mon Sep 17 00:00:00 2001 From: Dana Jacobsen <dana@acm.org> Date: Tue, 29 Oct 2013 08:37:48 -0700 Subject: [PATCH 1/2] Fix unsafe decoding in indef case From 8125d99 Mon Sep 17 00:00:00 2001 From: Dana Jacobsen <dana@acm.org> Date: Tue, 29 Oct 2013 08:53:09 -0700 Subject: [PATCH 2/2] Add second part of position check
timlegge
added a commit
to timlegge/perl-Convert-ASN1
that referenced
this pull request
May 23, 2021
From ce148a2 Mon Sep 17 00:00:00 2001 From: Dana Jacobsen <dana@acm.org> Date: Tue, 29 Oct 2013 08:37:48 -0700 Subject: [PATCH 1/2] Fix unsafe decoding in indef case From 8125d99 Mon Sep 17 00:00:00 2001 From: Dana Jacobsen <dana@acm.org> Date: Tue, 29 Oct 2013 08:53:09 -0700 Subject: [PATCH 2/2] Add second part of position check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue 14: "Unsafe decoding creates infinite loop".
Version 0.26 on CPAN is missing both position checks. The commit a year ago for issue 8 added one of them. This adds the other.
I did not add anything to the tests. Issue 14 has a simple test shown.
These changes should help with RT 27574 for Convert::PEM.