forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Witness charging order with limits #502
Merged
gballet
merged 38 commits into
kaustinen-with-shapella
from
witness-charging-order-with-limits
Oct 24, 2024
Merged
Witness charging order with limits #502
gballet
merged 38 commits into
kaustinen-with-shapella
from
witness-charging-order-with-limits
Oct 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
force-pushed
the
witness-charging-order-with-limits
branch
2 times, most recently
from
September 24, 2024 17:10
caa00f3
to
f7db43f
Compare
gballet
changed the base branch from
kaustinen-with-shapella
to
jsign-witness-fix
September 27, 2024 13:20
gballet
force-pushed
the
witness-charging-order-with-limits
branch
2 times, most recently
from
October 11, 2024 13:48
e220c74
to
f2b8d24
Compare
jsign
force-pushed
the
jsign-witness-fix
branch
from
October 15, 2024 19:06
b4b1ff0
to
9635cc1
Compare
gballet
force-pushed
the
witness-charging-order-with-limits
branch
from
October 22, 2024 11:31
17fd37d
to
032e1ab
Compare
gballet
changed the base branch from
jsign-witness-fix
to
kaustinen-with-shapella
October 22, 2024 11:56
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
* ci: new workflows for testing Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * nit Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * ci: fix stable consumption Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * fix Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * more fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * more fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * update tag Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> --------- Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com>
Signed-off-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com>
Co-authored-by: Ignacio Hagopian <jsign.uy@gmail.com> Signed-off-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
… + system contracts Signed-off-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com>
* fix makeCallVariantGasEIP4762 Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * fix Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * fix Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * fix Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * ci: target v0.0.6 Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * improve fix Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * add witness gas to "old" gas upon error Signed-off-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com> * workflow: remove target branch from list of branches --------- Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> Signed-off-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com> Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com>
jsign
force-pushed
the
witness-charging-order-with-limits
branch
from
October 23, 2024 20:11
5b01f99
to
87408a7
Compare
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
* fix selfdestruct Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * extcodecopy witness fix Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * blockhash fix Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * run ci Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * Apply suggestions from code review remove diff used for test * same thing in other file --------- Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another take on #495, which doesn't pass the gas usage function as a parameter, but the total amount of gas available. This approach has two advantages:
UseGas
function signature inmaster
for the live tracer, which will make it trickier to handleThe difficulty was distinguishing the gas that is to be charged (consumed), from the gas that is requested (wanted). If
wanted > charged
then it is known that the contract ran out of gas.In order to do so
touch*
functions are changed to return theconsumed
andwanted
gas. Locations will only be added to the witness ifconsumed == wanted
.Touch
functions change to only return thewanted
gas, so that thegas*
functions can return it (in order to let the interpreter loop know that the dynamic gas is too much, while only adding locations that were fully paid for to the witness.consumed < wanted
comparison to figure out if the subcall ran out of gas.