eth/downloader: fix error aggregator (ethereum#27217)

gballet · May 5, 2023 · 79a57d4 · 79a57d4
1 parent ffda2c6
commit 79a57d4
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/eth/downloader/downloader.go b/eth/downloader/downloader.go
@@ -663,8 +663,11 @@ func (d *Downloader) spawnSync(fetchers []func() error) error {
 			// it has processed the queue.
 			d.queue.Close()
 		}
-		if err = <-errc; err != nil && err != errCanceled {
-			break
+		if got := <-errc; got != nil {
+			err = got
+			if got != errCanceled {
+				break // receive a meaningful error, bubble it up
+			}
 		}
 	}
 	d.queue.Close()