fix: remove extra tab binding #61
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the logic for setting the
fifc_keybindingalways binds the Tab alongside what the user has configured. This does not seem necessary, since the code above the bind takes care of settingfifc_keybindingto a default value, so a single bind should be enough and allow for a user override.fifc/conf.d/fifc.fish
Lines 6 to 17 in a01650c
Looking at the code this seems to be a regression from 64433fa. It looks like this worked previously.
Unless there is a reason for keeping it this way, this PR should restore the functionality, by removing the extraneous bind.