Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward port cleanup #14

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Forward port cleanup #14

merged 2 commits into from
Nov 30, 2023

Conversation

quarkytale
Copy link
Collaborator

Changes:

  • Updated build instructions
  • Added package dependencies
  • Gazebo version logic

@quarkytale
updated build instructions and dependencies
9cf8631 
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
@quarkytale
version logic
af4be74 
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
@quarkytale quarkytale marked this pull request as ready for review November 16, 2023 00:32
azeey
azeey approved these changes Nov 30, 2023
View reviewed changes
ros_gz_example_gazebo/hooks/ros_gz_example_gazebo.sh.in
@@ -1,2 +1,2 @@
ament_prepend_unique_value GZ_SIM_RESOURCE_PATH "$AMENT_CURRENT_PREFIX/share/@PROJECT_NAME@/worlds"
ament_prepend_unique_value GZ_SIM_PLUGIn_PATH "$AMENT_CURRENT_PREFIX/lib/@PROJECT_NAME@"
ament_prepend_unique_value GZ_SIM_PLUGIN_PATH "$AMENT_CURRENT_PREFIX/lib/@PROJECT_NAME@"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch, nice catch!

@quarkytale quarkytale merged commit b7bf3d5 into main Nov 30, 2023
@quarkytale quarkytale deleted the cleanup branch November 30, 2023 23:20
@Ryanf55
Copy link
Contributor

Ryanf55 commented Apr 19, 2024 •
edited
Loading

Was this tested on harmonic? It doesn't work on my system, and there's lots of warnings in the SDF.

@quarkytale
Copy link
Collaborator Author

@Ryanf55 What warnings are you getting, can you please open an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeey azeey azeey approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quarkytale @Ryanf55 @azeey