Skip to content

Migrate to Qt6 #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Migrate to Qt6 #666

wants to merge 25 commits into from

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 25, 2025 •
edited
Loading

🎉 New feature

Built on top of #657 (and replaces that PR)

Related PR in gz-sim: gazebosim/gz-sim#2832

Summary

See PR description in #657. Apart from updating CMake calls and QML syntax to Qt6, one important change to highlight is:

plugin's name is prepended with an underscore (_) since properties that start with an uppercase letter are not allowed in Qt6

This resulted in changes in almost all the QML files in our GUI plugins. In order to call C++ functions from QML, the syntax is now _ClassName.Function() instead of ClassName.Function().

All TODOs mentioned in that PR has been addressed

CI status

Depends on:

Please see #673 that test these changes using custom CI branches. All checks are now green.

Plugins / Examples Status

I tested all gui plugins and examples in gz-gui (on ubuntu) to make sure they work in Qt6.

Here are their statuses:

Plugins

  • camera_fps
  • camera_tracking
  • camera_tracking_config
  • grid_config
  • image_display
  • interactive_view_control
  • key_publisher
  • marker_manager
  • minimal_scene
  • navsat_map (macOS only, needs Qt Location)
  • plotting
  • point_cloud
  • publisher
  • screenshot
  • shutdown_button
  • tape_measure
  • teleop
  • topic_echo
  • topic_viewer
  • transport_scene_manager
  • world_control
  • world_stats

Examples

standalone:

  • custom_drawer
  • dialogs
  • marker
  • point_cloud
  • scene_provider
  • start_dialog
  • window

plugin:

  • custom_context_menu
  • dialog_from_plugin
  • gz_components
  • hello_plugin
  • multiple_qml

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

azeey added 7 commits February 21, 2025 15:23
@azeey
WIP
51aa0a1 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey
Fix GzSpinBox in cases where the value property has a binding
e118488 
Before this fix, if the value property has a binding instead of a value,
any modification from the GUI (e.g. hitting the up arrow on the spin
box) would not actually change the displayed value because it is
immediately reset back to the value set by the binding. This is the case
in the `GzPose` module and the effect can be easily be seen in the
`GridConfig` plugin. To test, run:

`gz gui -c examples/config/grid_config.config`

You will see that, before this change, modifying the x,y,z,roll,pitch,
yaw values actually changes the grid configuration, but the updated values are
not displayed in the spinbox.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey
Handle decimal factor changes
9e7a0c8 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey
Remove debug logs
b6f401d 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey
Merge branch 'fix_gridconfig' into azeey/qt6_simple
e462f9c
@azeey
WIP
2726836 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey
Update packages.apt
c2d720d 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@iche033 iche033 requested a review from jennuine as a code owner March 25, 2025 21:06
@iche033 iche033 mentioned this pull request Mar 25, 2025
Open
40 tasks
@iche033 iche033 marked this pull request as draft March 25, 2025 22:12
@iche033
fixes for topic viewer's tree view, file dialogs, qml to cpp prop bin…
9c27bd1 
…dings

Signed-off-by: Ian Chen <ichen@openrobotics.org>
iche033 added 3 commits March 29, 2025 01:40
@iche033
fix transport plotting, all examples
9d397a4 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
fixing tests
3c3b3cf 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
testing
9fe860e 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 changed the base branch from azeey/qt6_simple to main April 3, 2025 01:34
iche033 added 4 commits April 3, 2025 01:35
@iche033
test sleeping:
f538d69 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
fix merge and grid config color dialog
e8a346c 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
testing
39aef4b 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
increase sleep
f96a1a4 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@mergify mergify bot mentioned this pull request Apr 3, 2025
Draft
iche033 added 6 commits April 4, 2025 18:24
@iche033
use Q_DECLARE_OPAQUE_POINTER
dd93d98 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
create metal texture
43bc6aa 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
deprecation warnings on homebrew
0ec0b21 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
merge from main
54fb00f 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
fix navsat map plugin on mac
7fcd13d 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
fix title in reset dialog on mac
cd5d6cb 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@mergify Mergify
Copy link

mergify bot commented Apr 8, 2025

⚠️ The sha of the head commit of this PR conflicts with #673. Mergify cannot evaluate rules on this PR. ⚠️

iche033 added 4 commits April 8, 2025 23:06
@iche033
fix shutdown issue
050974a 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
fix shutdown issue
ac61536 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
Merge branch 'ci_matching_branch/iche033/qt6' into iche033/qt6
e483f1f
@iche033
style
03c2164 
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 changed the title More Qt6 changes Migrate to Qt6 Apr 9, 2025
@iche033 iche033 marked this pull request as ready for review April 9, 2025 23:13
@iche033 iche033 requested a review from caguero April 9, 2025 23:13
@iche033 iche033 added the 🪵 jetty Gazebo Jetty label Apr 10, 2025
@iche033 iche033 mentioned this pull request Apr 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennuine jennuine Awaiting requested review from jennuine jennuine is a code owner

@caguero caguero Awaiting requested review from caguero

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
🪵 jetty Gazebo Jetty
Projects
Core development
Status: Inbox
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iche033 @azeey