GzCodeCoverage: ignore lcov errors #497
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`make coverage` currently fails on 24.04 due to lcov errors and warnings. This allows lcov errors and warnings to be printed and ignores many of them. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
j-rivero
reviewed
Apr 29, 2025
| COMMAND ${LCOV_PATH} ${_branch_flags} -q --no-checksum | ||
| --directory ${PROJECT_BINARY_DIR} --capture | ||
| --output-file ${_outputname}.info 2>/dev/null | ||
| --ignore-errors gcov,gcov |
There was a problem hiding this comment.
Does it make sense instead of ignoring categories doing it per files / per directories, something like:
--exclude '/usr/include/*' \
--exclude '*_TEST.cc' \
There was a problem hiding this comment.
we use --remove with lots of path wildcards on line 152. I'm not sure what the best approach is here. I think we would need to test with more packages as well so see if more --ignore-errors categories are needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes some errors related to code coverage on 24.04
Summary
Running
make coveragecurrently fails on 24.04 due to lcov errors and warnings. This is difficult to see because these warnings are currently redirected to/dev/null. Through debugging in gazebosim/gz-utils#174, testing with nightly builds of gz-cmake5, and viewing GitHub workflow console logs (for example), several types of errors were identified that could be ignored to allowmake coverageto pass for gz-utils.There are other issues with code coverage, specifically with uploading coverage reports (similar to MicrosoftPremier/VstsExtensions#237). I will open a separate issue about this referencing codecov/feedback#301 and https://docs.codecov.com/docs/codecov-uploader.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.