-
Notifications
You must be signed in to change notification settings - Fork 0
Relocate .so files in lib (plugin) packages intead of in development packages #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
j-rivero
wants to merge
6
commits into
main
Choose a base branch
from
jrivero/relocate_plugins
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…packages Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
Contributor
Author
Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
Contributor
Author
|
Moved the media files in 37884f3. Need them to run the rendering plugins in ogre2. |
Contributor
Author
|
Currently using the following Dockerfle to test this server-only use case: FROM ghcr.io/j-rivero/gazebo:jetty-core
RUN apt-get update \
&& apt-get install -y \
curl \
git \
lsb-release \
python3-venv \
vim \
zip \
unzip \
&& rm -rf /var/lib/apt/lists/*
RUN curl -s https://packages.osrfoundation.org/gazebo.gpg -o /usr/share/keyrings/pkgs-osrf-archive-keyring.gpg \
&& echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/pkgs-osrf-archive-keyring.gpg] http://packages.osrfoundation.org/gazebo/ubuntu-prerelease $(lsb_release -cs) main" | tee /etc/apt/sources.list.d/gazebo-pre.list > /dev/null
RUN apt-get update && apt-get install -y \
libgz-physics9-dartsim \
libgz-rendering10-ogre2 \
&& rm -rf /var/lib/apt/lists/*
RUN curl -s https://packages.osrfoundation.org/gazebo.gpg -o /usr/share/keyrings/pkgs-osrf-archive-keyring.gpg \
&& echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/pkgs-osrf-archive-keyring.gpg] http://packages.osrfoundation.org/gazebo/ubuntu-nightly $(lsb_release -cs) main" | tee /etc/apt/sources.list.d/gazebo-nightly.list > /dev/null
# Download the zip file https://build.osrfoundation.org/job/gz-sim10-debbuilder/400/artifact/pkgs/*zip*/pkgs.zip and unzip
RUN curl -L -o /tmp/pkgs.zip https://build.osrfoundation.org/job/gz-sim10-debbuilder/400/artifact/pkgs/*zip*/pkgs.zip \
&& unzip /tmp/pkgs.zip -d /tmp/gzpkgs
RUN dpkg -i /tmp/gzpkgs/pkgs/libgz-sim10_*.deb || true \
&& dpkg -i /tmp/gzpkgs/pkgs/libgz-sim10-plugins_*.deb || true \
&& apt-get update \
&& apt-get install -f -y --no-install-recommends \
&& dpkg -i /tmp/gzpkgs/pkgs/gz-sim10-server_*.deb
# Be sure that libgz-rendering10-ogre2 is version 10.0.0-2pre or fails
RUN dpkg -l | grep libgz-rendering10-ogre2 | grep 10.0.0-2 |
Contributor
Author
|
Testing the upgrade in stable: FROM ghcr.io/j-rivero/gazebo:jetty-full AS base
RUN curl -s https://packages.osrfoundation.org/gazebo.gpg -o /usr/share/keyrings/pkgs-osrf-archive-keyring.gpg \
&& echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/pkgs-osrf-archive-keyring.gpg] http://packages.osrfoundation.org/gazebo/ubuntu-prerelease $(lsb_release -cs) main" | tee /etc/apt/sources.list.d/gazebo-prerelease.list > /dev/null
RUN apt-get update
FROM base AS test_upgrade
RUN apt-get upgrade -y
FROM base AS test_gz_physics
RUN apt-get install -y -- libgz-rendering10-dev
FROM base AS test_gz_dartsim
RUN apt-get install -y libgz-rendering10-ogre2-dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A twin of gazebo-release/gz-physics9-release#4, related to gazebo-release/gz-sim8-release#8.
The installation of the different rendering plugin packages (libgz-rendering10-{ogre1|ogre2}) is not sufficient for gz server
to recognize them as being installed since it expects to find the files libgz-rendering-{engine}-plugin.so and those files were being shipped in the development packages (libgz-rendering10-{ogre1|ogre2}-dev).
This change moves the .so symlinks from the -dev packages to the runtime packages where they belong, ensuring plugins can be properly discovered at runtime without requiring the -dev packages to be installed.
The Breaks/Replaces fields ensure smooth upgrades from previous versions where the files were in the wrong package.