Hibernate Type Of Stop doesn't hibernate computer

[robotics13]

When I configure WinNUT to Hibernate my computer the Shutdown GUI will display when the NUT Server sends the FSD signal. The Shutdown GUI will perform the countdown and then hang. When configured to Shutdown instead of hibernate, the shutdown process executes properly.

Steps to reproduce:

1. Configure WinNUT Shutdown Options as follows

• Type of Stop = Hibernate
• Delay to SHutdown (sec) = 15
• Shutdown on Nut's FSD Signal = Checked

2. Disconnect UPS from AC power, wait for NUT Server to send FDS
3. Shutdown GUI will appear, wait for counter to reach zero
4. Shutdown GUI will hang and computer will stay powered on

I suspect this has something to do with the calls to SetSystemPowerState in the Select Cast statement at line 979 in WinNUT.vb. It looks a bit odd passing a Boolean value when the function is declared as expecting an integer. https://www.tek-tips.com/viewthread.cfm?qid=1086465 talks about similar code only passing integers 1 and 0 instead of Booleans. It has been years since I messed with VB.Net so passing a Boolean could be valid, it just looks off.

My computer is running Windows 10 21H1, NUT Server is the built in Synology NUT server, running latest version of WinNUT

[robotics13]

I took a second look at this and the problem was my computer does not have the Hibernate option enabled.

Not sure if the a try catch around the Hibernate command would be helpful or if an update to the documentation/UI would be better.

[Ha4ipuri]

Same. Shutdown works and hibernation and sleep doesn't. Windows 10, WinNUT 2.0.7722.30975

[johnehler]

I can confirm this. I was trying to use the "shutdown on FSD" setting with a Synology NAS. It only works for "Shutdown" and NOT for "hibernate" or "sleep". If you have a delay set for hibernate or sleep, the program will crash after the delay.

[g-cranston]

I have come all the way to the same final hurdle: Shutdown works great, Hibernate/Sleep just don't trigger an action, whether at the end of the timer, clicking the immediate shutdown button on the timer, or without timer. I have hibernate switched and working otherwise. Have tried this on a PC and laptop, for both v2.0.7722.30975 (stable) and v2.1.7740.35837 (pre-release). Windows 10 21H2 / 21H1, built-in Synology UPS server. If power is restored, timer window disappears and it carries on as normal.

I don't know if it has any bearing at all, but on my current windows machines, the command:
shutdown.exe /h /t 5 does nothing (shows the syntax guide) when I would expect it to delay hibernation for 5 secs from documentation.

Whereas:
shutdown.exe /h hibernates immediately as it should do.

[g-cranston]

#116

I think a possible answer to this may have been suggested in a new post.

[g-cranston]

This worked for me as hoped, once SetSystemPowerState was swapped for SetSuspendState, on Windows 10. Not sure quality of my coding, but this worked for me:

Public Sub Shutdown_Action()
     Select Case WinNUT_Params.Arr_Reg_Key.Item("TypeOfStop")
        Case 0
             Process.Start("C:\WINDOWS\system32\Shutdown.exe", "-f -s -t 0")
       Case 1
             SetSystemPowerState(True, 0)
       Case 2
             SetSystemPowerState(False, 0)
     End Select
End Sub

Changed to:

Declare Function SetSuspendState Lib "PowrProf" (ByVal Hibernate As Integer, ByVal ForceCritical As Integer, ByVal DisableWakeEvent As Integer) As Integer

    Public Sub Shutdown_Action()
        Select Case WinNUT_Params.Arr_Reg_Key.Item("TypeOfStop")
            Case 0
                Process.Start("C:\WINDOWS\system32\Shutdown.exe", "-f -s -t 0")
            Case 1
                SetSuspendState(False, False, True)  'suspended
            Case 2
                SetSuspendState(True, False, True)   'hibernated
        End Select
    End Sub   

[p7654]

Hi g-cranson, Is there a fork or installable download that contains this fix?

[g-cranston]

https://github.com/g-cranston/WinNUT-Client

Have made the changes in a fork in case it is of use (plus another fix for a different issue that works for me). Apologies if I haven't done this in the appropriate manner (first time doing this on github).

[gbakeman]

Hey everyone, again apologies for letting these bugs sit for so long without an update. I've been working for a very long time on a big change, but I'm realizing how important it is that we get these high profile bugs fixed.

I think @gawindx gave me write access to this repo. @g-cranston do you want to make a pull request here with your changes, then I'll pull it in along with a few other waiting PRs and push out an update?

[g-cranston]

@gbakeman Hopefully I've done the pull request right - seem to be two modifications in one rather than separated.

Thank you for all you and @gawindx have done for this project, a huge and really worthwhile piece of work. Has really solved my situation where APC's solution didn't!

[gbakeman]

I'm glad I could be a part of this, and thank you for the PRs. I'm away from the dev computer right now but I'll make it a priority to get your work by next week, hopefully before.

[gbakeman]

Excellent work by the way, thank you! I just found out that I made a mistake sleeping on @gawindx 's invitation. Apparently they expire in 7 days, and that was a long time ago when they sent it. I'll see if I can contact him (maybe you can too if you want to do more?)