Skip to content

Conversation

@Majsvaffla
Copy link

I thought it would be a neat addition to support auto-reload like django-admin runserver does. That is usually what you want while developing.

@Majsvaffla Majsvaffla force-pushed the django-autoreloader branch 2 times, most recently from f64e846 to bd6819a Compare May 12, 2023 11:55
@gavinwahl
Copy link
Owner

Good idea, but I don't think it should be the default

@Majsvaffla
Copy link
Author

Good idea, but I don't think it should be the default

Fair enough :)

I've also been thinking of adding support for watchfiles. Having more reloader options also promotes not having a default I think.

@gavinwahl
Copy link
Owner

If autoreloading is already in Django, what's the point of using something else?

@Majsvaffla
Copy link
Author

It's a bit hacky to hook into the Django autoreloader since it's not really designed for that. Watchfiles also performs better than the reloader mechanism built into Django from my experience.

@Majsvaffla
Copy link
Author

I've changed it to opt-in as you proposed 🙂 Use --reload to enable autoreload.

Regarding watchfiles, I guess this would use watchfiles implicitly if the django project were using django-watchfiles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants