Added option to open stack overflow url directly, closes #191

[pspiagicw]

The Pull Request adds support for opening stackoverflow urls through socli.This was my first pull request so I worked on something that was easy.
If url is not eligible to open in socli , it opens in the browser . If url points to tag it opens the corresponding tag in socli.
If it is a normal question url it opens within socli.
To be just sure I also mentioned this in the Issues section.

[hedyhli]

Thank you for your first PR, I will review it shortly.

CC @gautamkrishnar

[gautamkrishnar]

Can we add some tests for this new argument? Please add it to socli/tests

[pspiagicw]

Okay will add as soon as possible.

[gautamkrishnar]

@prathampowar2001 please take your time.

[hedyhli]

Oh and I think --open-url instead of --open_url will be better for command line options

Edit: resolved in commit after

[gautamkrishnar]

Tests LGTM 👍

[hedyhli]

@prathampowar2001 The travis tests are failing due to using namespace.open-url please update accordingly as to the comments above open_url, everything else seems ok. Please also make sure you test your functionalities (--open-url with valid/invalid URLs)

[pspiagicw]

I tested manually the functionality --open-url or -o with multiple urls
This is my analysis
Stack Overflow url's that are viewable in socli are of three types

1. https://stackoverflow.com/questions/tagged/**tag**
   This is handled by extracting the tag using regular expression and opening the corresponding tag in socli.

2. https://stackoverflow.com/questions/**id and question**
   This is handled by opening the url directly in socli.

3. https://stackoverrflow.com/tags/**tag**
   This is handled by extracting the tag and opening it in socli.

4.https://stackoverflow.blog/****
This is handled by warning the user and opening the browser.

If a url does not contain https:// , eg. stackoverflow.com , It adds https:// to the start of it.

If it is not a stackoverflow url it warns the user and opens in a browser.

For a invalid url it check's it with a request module and if invalid then warns the user and exits

I have manually tested with atleast 10-15 url's

All the above is included in the next commit

[hedyhli]

Looks good! 👍 I will test it again tomorrow if gautamkrishnar doesn't merge this today

[hedyhli]

Oh! Looks like it's failing codacy, you could just do a request.get without assigning it to a variable to resolve one of the unused variable issues. And then there seems to be trailing whitespaces on an if statement:

https://app.codacy.com/manual/gautamkrishnar/socli/pullRequest?prid=5814058

[pspiagicw]

It looks like all done and dusted . Thank you for the pain and effort you all took to correct my silly or sometimes irritating mistakes . And definately it was a learning experience for me as I contributed to a real open source project for the first time and learnt multiple things that would help me in the future . As a python and github newbie it was a very good experience .

[hedyhli]

Looks better now 👍🏼 Even though the raising connection error might confuse someone reading it but I do not think that matters and can be fixed later, thank you for your effort 😃

Will probably be merged after @gautamkrishnar checks it again

[gautamkrishnar]

@hedythedev @prashantchahal26 just updated the code and moved the requests.get after the if check for the correct URL so that users don't have to trigger an api call if the check fails.

[gautamkrishnar]

Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- socli/socli.py  11
         

Clones added
============
- socli/tests/test_socli.py  5
         

See the complete overview on Codacy

[gautamkrishnar]

@hedythedev really sorry for deleting your comment that was an accident.

[gautamkrishnar]

@all-contributors please add @prathampowar2001 for code

[allcontributors]

@gautamkrishnar

I've put up a pull request to add @prathampowar2001! 🎉

[gautamkrishnar]

@prathampowar2001 thanks a lot for the contribution. You rocks ⭐