docker: Match s3proxy.v4-max-non-chunked-request-size default (128 MB)#785
Merged
gaul merged 1 commit intogaul:masterfrom Mar 1, 2025
Merged
docker: Match s3proxy.v4-max-non-chunked-request-size default (128 MB)#785gaul merged 1 commit intogaul:masterfrom
gaul merged 1 commit intogaul:masterfrom
Conversation
- gaul#594 changed the hardcoded default value of `v4MaxNonChunkedRequestSize` to 128 MB - The 128 MB default only kicks in if the `s3proxy.v4-max-non-chunked-request-size` config is not set - However, when using the Docker image (in k8s, for example), if you don't explicitly override the `S3PROXY_V4_MAX_NON_CHUNKED_REQ_SIZE` env variable, the `run-docker-container.sh` sets this env var [1] to a default of 33554432 bytes (~32 MB) - This commit changes this defualt to 128 MB, to match the default value defined in the code itself This change makes it such that an un-initiated user running s3Proxy via Docker / k8s does not run into an error of the form: 400 MaxMessageLengthExceeded Your request was too big , when uploading a file between 32 - 128 MB. [1] https://github.com/gaul/s3proxy/blob/master/src/main/resources/run-docker-container.sh#L26
Owner
|
Thank you for your contribution @musabshak! |
MareStare
added a commit
to MareStare/philomena
that referenced
this pull request
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v4MaxNonChunkedRequestSizeto 128 MBs3proxy.v4-max-non-chunked-request-sizeconfig is not setS3PROXY_V4_MAX_NON_CHUNKED_REQ_SIZEenv variable, therun-docker-container.shsets this env var [1] to a default of 33554432 bytes (~32 MB)This change makes it such that an un-initiated user running s3Proxy via Docker / k8s does not run into an error of the form:
400 MaxMessageLengthExceeded Your request was too big
, when uploading a file between 32 - 128 MB.
[1] https://github.com/gaul/s3proxy/blob/master/src/main/resources/run-docker-container.sh#L26