Update cli.py #323
Merged
Update cli.py #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for alerting us to this issue! I think these changes make sense, but I would prefer them being optional, or even auto-detecting whether the display might support the extended unicode. I'll look into this and see if I can make some changes to this branch. |
emdoyle
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
I use your lib with github runner, but I have a problem during the display of the result in this environment :
ERROR : UnicodeEncodeError: 'charmap' codec can't encode character '\u2705' in position 0: character maps to
So I propose this update to work also in github display ! \o/
Thanks for your work, this tools is verry usefull ! 💪