Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Finish Content Sync support #191

Merged
merged 7 commits into from
Oct 25, 2021
Merged

feat: Finish Content Sync support #191

merged 7 commits into from
Oct 25, 2021

Conversation

TylerBarnes
Copy link
Contributor

@TylerBarnes TylerBarnes commented Aug 27, 2021 •
edited
Loading

This PR:

  • Fixes the double initialization of all action monitor classes
  • Removes a dead file
  • Moves all preview logic to happen on preview template redirect instead of on save_post to make previews more reliable
  • Adds a ?gatsby_preview=true param to the preview template url as WP core only treats every second preview load with no content changes as a preview but we want every preview load to be treated as a preview
  • Removes legacy preview as the maintenance burden will be too high to keep Content Sync & the old WP preview loader

@TylerBarnes TylerBarnes requested a review from smthomas August 27, 2021 23:00
smthomas
smthomas reviewed Aug 27, 2021
View reviewed changes
Copy link
Contributor

@smthomas smthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this looks good. Just one comment.

src/Admin/Preview.php Outdated Show resolved Hide resolved
@TylerBarnes TylerBarnes changed the base branch from master to prerelease October 25, 2021 19:38
@TylerBarnes TylerBarnes requested a review from smthomas October 25, 2021 19:40
@TylerBarnes TylerBarnes changed the title feat: move preview webhooks to template logic feat: Finish Content Sync support Oct 25, 2021
@TylerBarnes TylerBarnes requested a review from veryspry October 25, 2021 19:41
@TylerBarnes TylerBarnes merged commit 841887f into prerelease Oct 25, 2021
@TylerBarnes TylerBarnes deleted the feat/move-preview-webhooks-to-template-logic branch October 25, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smthomas smthomas Awaiting requested review from smthomas

@veryspry veryspry Awaiting requested review from veryspry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerBarnes @smthomas