Skip to content
This repository has been archived by the owner on Dec 22, 2021. It is now read-only.

RFC: Remove special layouts from v2 #2

Merged
merged 7 commits into from
May 4, 2018
Merged

RFC: Remove special layouts from v2 #2

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1009e3f
Add RFC for removing our special layout components
KyleAMathews Apr 6, 2018
4849360
Fix spelling errors
KyleAMathews Apr 6, 2018
b65a9b0
Copy edits
KyleAMathews Apr 6, 2018
cd3f5ce
Add link to the original RFC
KyleAMathews Apr 6, 2018
37e96c6
typo
KyleAMathews Apr 6, 2018
f79f111
They can accept variables (though little used it seems)
KyleAMathews Apr 6, 2018
6d5b1d6
Update 0000-remove-special-layout-components.md
KyleAMathews Apr 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add link to the original RFC
  • Loading branch information
@KyleAMathews
KyleAMathews committed Apr 6, 2018
commit cd3f5ce386ea7ecec6809897065928fc2851760c
2 changes: 2 additions & 0 deletions text/0000-remove-special-layout-components.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ Gatsby v1 includes a special "layout" component that can wrap page components.
This RFC proposes removing it and encouraging people to use normal React
component composition.

[Previous discussiong](https://github.com/gatsbyjs/gatsby/issues/3830)

# Basic example

Currently sites might have a global layout components like:
Expand Down