query-benchmark #9379
Merged
query-benchmark #9379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
approved these changes
Oct 25, 2018
|
|
||
| output=$(rm -rf .cache && gatsby build | grep "run graphql queries") | ||
| echo $output | cut -d' ' -f 6 | ||
|
|
There was a problem hiding this comment.
this (kind of) limits where we can use this benchmark (cough - windows) :) but that's just utility to grab time for running queries, so I wouldn't say that it is a blocker
There was a problem hiding this comment.
It's a sign of the times when windows doesn't even enter my head. I'll leave it in as an optional useful tool for non windows users.
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of WIP PR #9338. Submitting this as its own PR to reduce the size of the other PR and since it's useful on its own. The recording.md won't make sense without the other PR, but I think that's ok.