-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: implement babel-preset-gatsby into packages that need it #9323
Conversation
…atsby first (gatsbyjs#9322)" This reverts commit a392fb4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks polished and ready from the docs perspective! Just curious about the purpose of these changes and whether any other docs would need to include changes!
@shannonbux this was actually already approved in #8724, probably should've clarified that. We had to release the actual presets first and then we can get these packages built out that contain these changes. Thank you for taking a look though! |
Going to get this in tomorrow ⏲ |
👀 🎉
|
…byjs#9323) * Revert "chore: revert extra package changes to publish babel-preset-gatsby first (gatsbyjs#9322)" This reverts commit a392fb4. * chore: implement little fix and add to gtag * chore: add babel-preset-gatsby-package dep where it's needed * chore: bump versionin gatsby * chore: update plop file * chore: remove src/ for babel-preset-gatsby-package * test: get tests running for packages without src/ directories * chore: add babel-preset-gatsby-package for correctness @pieh * chore: add missing comma
…byjs#9323) * Revert "chore: revert extra package changes to publish babel-preset-gatsby first (gatsbyjs#9322)" This reverts commit a392fb4. * chore: implement little fix and add to gtag * chore: add babel-preset-gatsby-package dep where it's needed * chore: bump versionin gatsby * chore: update plop file * chore: remove src/ for babel-preset-gatsby-package * test: get tests running for packages without src/ directories * chore: add babel-preset-gatsby-package for correctness @pieh * chore: add missing comma
This PR implements the changes in the babel-preset-gatsby PR.