Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: implement babel-preset-gatsby into packages that need it #9323

Merged
merged 10 commits into from
Oct 29, 2018

Conversation

DSchau
Copy link
Contributor

@DSchau DSchau commented Oct 23, 2018

This PR implements the changes in the babel-preset-gatsby PR.

@DSchau DSchau requested a review from a team as a code owner October 23, 2018 19:48
@DSchau DSchau requested a review from a team October 23, 2018 19:48
Copy link
Contributor

@shannonbux shannonbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks polished and ready from the docs perspective! Just curious about the purpose of these changes and whether any other docs would need to include changes!

@DSchau
Copy link
Contributor Author

DSchau commented Oct 23, 2018

@shannonbux this was actually already approved in #8724, probably should've clarified that. We had to release the actual presets first and then we can get these packages built out that contain these changes.

Thank you for taking a look though!

@DSchau
Copy link
Contributor Author

DSchau commented Oct 24, 2018

Going to get this in tomorrow ⏲

@DSchau DSchau merged commit 2788f93 into gatsbyjs:master Oct 29, 2018
@DSchau DSchau deleted the babel-preset-gatsby-impl branch October 29, 2018 15:07
@DSchau
Copy link
Contributor Author

DSchau commented Oct 29, 2018

👀 🎉

Successfully published:
 - babel-plugin-remove-graphql-queries@2.5.1
 - babel-preset-gatsby-package@0.1.2
 - babel-preset-gatsby@0.1.2
 - gatsby-cli@2.4.4
 - gatsby-codemods@1.0.6
 - gatsby-dev-cli@2.4.6
 - gatsby-image@2.0.18
 - gatsby-link@2.0.6
 - gatsby-plugin-canonical-urls@2.0.7
 - gatsby-plugin-catch-links@2.0.6
 - gatsby-plugin-coffeescript@2.0.6
 - gatsby-plugin-create-client-paths@2.0.2
 - gatsby-plugin-emotion@2.0.6
 - gatsby-plugin-facebook-analytics@2.0.1
 - gatsby-plugin-feed@2.0.9
 - gatsby-plugin-fullstory@2.0.1
 - gatsby-plugin-glamor@2.0.6
 - gatsby-plugin-google-analytics@2.0.7
 - gatsby-plugin-google-gtag@1.0.2
 - gatsby-plugin-google-tagmanager@2.0.6
 - gatsby-plugin-guess-js@1.0.2
 - gatsby-plugin-jss@2.0.3
 - gatsby-plugin-layout@1.0.5
 - gatsby-plugin-less@2.0.7
 - gatsby-plugin-lodash@3.0.2
 - gatsby-plugin-manifest@2.0.7
 - gatsby-plugin-netlify-cms@3.0.5
 - gatsby-plugin-netlify@2.0.3
 - gatsby-plugin-nprogress@2.0.6
 - gatsby-plugin-offline@2.0.10
 - gatsby-plugin-page-creator@2.0.2
 - gatsby-plugin-postcss@2.0.1
 - gatsby-plugin-preact@2.0.7
 - gatsby-plugin-react-css-modules@2.0.3
 - gatsby-plugin-react-helmet@3.0.1
 - gatsby-plugin-remove-trailing-slashes@2.0.4
 - gatsby-plugin-sass@2.0.2
 - gatsby-plugin-sharp@2.0.9
 - gatsby-plugin-sitemap@2.0.2
 - gatsby-plugin-styled-components@3.0.1
 - gatsby-plugin-styled-jsx@3.0.2
 - gatsby-plugin-styletron@3.0.2
 - gatsby-plugin-stylus@2.0.2
 - gatsby-plugin-subfont@1.0.2
 - gatsby-plugin-twitter@2.0.7
 - gatsby-plugin-typescript@2.0.1
 - gatsby-plugin-typography@2.2.1
 - gatsby-react-router-scroll@2.0.1
 - gatsby-remark-autolink-headers@2.0.9
 - gatsby-remark-code-repls@2.0.1
 - gatsby-remark-copy-linked-files@2.0.6
 - gatsby-remark-custom-blocks@2.0.1
 - gatsby-remark-embed-snippet@3.0.2
 - gatsby-remark-graphviz@1.0.3
 - gatsby-remark-images@2.0.5
 - gatsby-remark-katex@2.0.6
 - gatsby-remark-prismjs@3.0.3
 - gatsby-remark-responsive-iframe@2.0.6
 - gatsby-remark-smartypants@2.0.6
 - gatsby-source-contentful@2.0.7
 - gatsby-source-drupal@3.0.6
 - gatsby-source-faker@2.0.1
 - gatsby-source-filesystem@2.0.6
 - gatsby-source-graphql@2.0.5
 - gatsby-source-hacker-news@2.0.6
 - gatsby-source-lever@2.0.1
 - gatsby-source-medium@2.0.1
 - gatsby-source-mongodb@2.0.6
 - gatsby-source-npm-package-search@2.0.1
 - gatsby-source-wikipedia@2.0.2
 - gatsby-source-wordpress@3.0.10
 - gatsby-transformer-csv@2.0.3
 - gatsby-transformer-documentationjs@2.0.1
 - gatsby-transformer-excel@2.1.3
 - gatsby-transformer-hjson@2.1.2
 - gatsby-transformer-javascript-frontmatter@2.0.3
 - gatsby-transformer-javascript-static-exports@2.1.3
 - gatsby-transformer-json@2.1.5
 - gatsby-transformer-pdf@1.0.13
 - gatsby-transformer-react-docgen@2.1.2
 - gatsby-transformer-remark@2.1.10
 - gatsby-transformer-screenshot@2.0.5
 - gatsby-transformer-sharp@2.1.6
 - gatsby-transformer-sqip@2.0.4
 - gatsby-transformer-toml@2.1.2
 - gatsby-transformer-xml@2.0.3
 - gatsby-transformer-yaml@2.1.4
 - gatsby@2.0.32
 - graphql-skip-limit@2.0.1
lerna success published 89 packages

gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
…byjs#9323)

* Revert "chore: revert extra package changes to publish babel-preset-gatsby first (gatsbyjs#9322)"

This reverts commit a392fb4.

* chore: implement little fix and add to gtag

* chore: add babel-preset-gatsby-package dep where it's needed

* chore: bump versionin gatsby

* chore: update plop file

* chore: remove src/ for babel-preset-gatsby-package

* test: get tests running for packages without src/ directories

* chore: add babel-preset-gatsby-package for correctness @pieh

* chore: add missing comma
mwfrost pushed a commit to mwfrost/gatsby that referenced this pull request Apr 20, 2023
…byjs#9323)

* Revert "chore: revert extra package changes to publish babel-preset-gatsby first (gatsbyjs#9322)"

This reverts commit a392fb4.

* chore: implement little fix and add to gtag

* chore: add babel-preset-gatsby-package dep where it's needed

* chore: bump versionin gatsby

* chore: update plop file

* chore: remove src/ for babel-preset-gatsby-package

* test: get tests running for packages without src/ directories

* chore: add babel-preset-gatsby-package for correctness @pieh

* chore: add missing comma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants