WIP: added suggestion for rollup config #9201
for the gatsby package
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import babel from 'rollup-plugin-babel'; | ||
| import autoExternal from 'rollup-plugin-auto-external'; | ||
|
|
||
| export default { | ||
| input: 'cache-dir/gatsby-browser-entry.js', | ||
|
There was a problem hiding this comment. This will fail, unfortunately. We want the files to remain unbundled so that we can conditionally require certain files. For instance, if we take Bundling this for the browser honestly just wouldn't work, I don't think, because it'll trace those dependencies, exclude conditional requires that we'd want in certain phases, and then create a (smaller, but not as functional) bundle file. There was a problem hiding this comment. fair point. i'm not familiar enough with the approach, so this is some of the detail i was hoping to tease out. there could possibly still be a way to accomplish as a bundle (or multiple), but that could be more of an investment than its worth at this point. maybe the better approach would be simple transpilation then, similar to what was done for the common js version, but with |
||
| plugins: [ | ||
| autoExternal(), | ||
| babel({ | ||
| presets: [[require(`path`).join(__dirname, `..`, `..`, `.babel-preset.js`), {modules: false}]], | ||
| runtimeHelpers: true, | ||
| exclude: ['./node_modules/**'] | ||
| }) | ||
| ], | ||
| output: [ | ||
| {file: 'lib/index.cjs.js', format: 'cjs', sourcemap: true}, | ||
|
There was a problem hiding this comment. the files produced here are the ones that should be referenced as the directory and file names can certainly be adjusted to fit your conventions, but i started with these to demonstrate the mechanics to start with. |
||
| {file: 'lib/index.es.js', format: 'es', sourcemap: true} | ||
| ] | ||
| }; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the output of the transpilation during the rollup build needs to preserve the es-module syntax so that rollup can properly do the rest of its processing. the default retains the previous behavior, but this allows overriding how the modules are handled.