Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] [gatsby-plugin-offline] fix: improve service worker initial caching #8183

Merged
merged 6 commits into from
Sep 17, 2018
Merged

[v2] [gatsby-plugin-offline] fix: improve service worker initial caching #8183

merged 6 commits into from
Sep 17, 2018

Conversation

vtenfys
Copy link
Contributor

@vtenfys vtenfys commented Sep 15, 2018 •
edited
Loading

Changes:

  • Run the onServiceWorkerActive API correctly by fixing the event handler
  • Remove the 100ms timeout for onServiceWorkerInstalled
  • Add a message API to the service worker and use this to cache initial resources, rather than using fetch after a timeout and hoping for the best
  • Cache the initial resources at onServiceWorkerActive rather than onServiceWorkerInstalled
  • Add support for handling external resources
  • Upgrade all Yarn packages, including Workbox to 3.5.0 - this is where most of the line count comes from

Note: we're currently not polyfilling Promise.all in sw-append.js - can we safely assume all browsers that support SWs also support promises?

Fixes #8145

@vtenfys
Copy link
Contributor Author

vtenfys commented Sep 15, 2018 •
edited
Loading

Just need to fix one or two tests done!

m-allanson
m-allanson approved these changes Sep 17, 2018
View reviewed changes
Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks @davidbailey00 👌

@m-allanson m-allanson merged commit 68d2fb1 into gatsbyjs:master Sep 17, 2018
@m-allanson
Copy link
Contributor

Oh I forgot to post this earlier...

can we safely assume all browsers that support SWs also support promises?

Yep, looks like it:

@KyleAMathews
Copy link
Contributor

Nice work @davidbailey00! 🙏

@haroldangenent haroldangenent mentioned this pull request Oct 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-allanson m-allanson m-allanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Offline plugin sometimes has a fetch error
3 participants
@vtenfys @m-allanson @KyleAMathews