Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] [scripts] feat: create build-examples script and fix some examples #8130

Merged
merged 7 commits into from
Sep 14, 2018
Merged

[v2] [scripts] feat: create build-examples script and fix some examples #8130

merged 7 commits into from
Sep 14, 2018

Conversation

vtenfys
Copy link
Contributor

@vtenfys vtenfys commented Sep 13, 2018

This allows us to test all examples with a single command. Currently failing examples:

  • hn (help wanted) no issue? works now
  • styleguide fixed
  • using-asciidoc fixed (same fix as styleguide)
  • using-jss fixed

Fixes #7718

@m-allanson
Copy link
Contributor

Nice, thanks! Want to run the script through https://www.shellcheck.net?

@vtenfys vtenfys changed the title [v2] [scripts] [WIP] feat: create build-examples script [v2] [scripts] [WIP] feat: create build-examples script and fix some examples Sep 13, 2018
@vtenfys vtenfys changed the title [v2] [scripts] [WIP] feat: create build-examples script and fix some examples [v2] [scripts] feat: create build-examples script and fix some examples Sep 13, 2018
Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pieh pieh merged commit a43a6e3 into gatsbyjs:master Sep 14, 2018

status=""

yarn boostrap &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱 I'll fix this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, whoops...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect breaks server rendering
4 participants