-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] [scripts] feat: create build-examples script and fix some examples #8130
Conversation
Nice, thanks! Want to run the script through https://www.shellcheck.net? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
|
||
status="" | ||
|
||
yarn boostrap && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😱 I'll fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, whoops...
This allows us to test all examples with a single command. Currently failing examples:
hn (help wanted)no issue? works nowstyleguidefixedusing-asciidocfixed (same fix as styleguide)using-jssfixedFixes #7718