Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Jest localstorage bug #7160

Merged
merged 2 commits into from
Aug 10, 2018
Merged

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Aug 8, 2018

If you run the tests with the latest jest version you run into this issue:
jestjs/jest#6766

This is the fix for it.

@KyleAMathews
Copy link
Contributor

Deploy preview for gatsbyjs failed.

Built with commit ae6f33b

https://app.netlify.com/sites/gatsbyjs/deploys/5b6b3c51c9659233306cedee

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Aug 8, 2018

Deploy preview for using-postcss-sass failed.

Built with commit 4c05d2c

https://app.netlify.com/sites/using-postcss-sass/deploys/5b6c0b1282d3f1607f4564c2

@KyleAMathews
Copy link
Contributor

Deploy preview for using-remark failed.

Built with commit ae6f33b

https://app.netlify.com/sites/using-remark/deploys/5b6b3c53c9659233306cee02

@gatsbybot
Copy link
Collaborator

gatsbybot commented Aug 8, 2018

Deploy preview for using-drupal ready!

Built with commit 4c05d2c

https://deploy-preview-7160--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Aug 8, 2018

Deploy preview for gatsbygram ready!

Built with commit 4c05d2c

https://deploy-preview-7160--gatsbygram.netlify.com

m-allanson
m-allanson previously approved these changes Aug 8, 2018
Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LekoArts 🙏

@m-allanson m-allanson merged commit 7bd43f1 into gatsbyjs:master Aug 10, 2018
@LekoArts LekoArts deleted the topics/jest-fix branch August 10, 2018 12:18
shobhitchittora pushed a commit to shobhitchittora/gatsby that referenced this pull request Aug 13, 2018
* Fixes: jestjs/jest#6766

* Add todo to remove this once it's fixed in Jest
porfirioribeiro pushed a commit to porfirioribeiro/gatsby that referenced this pull request Aug 22, 2018
* Fixes: jestjs/jest#6766

* Add todo to remove this once it's fixed in Jest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants