-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] revert compling cache-dir and remove non standard code from cache-dir #6183
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a760efb
dont transpile cache-dir - just remove flow types
pieh fb8efee
flow-remove-types doesnt support optional chaining
pieh 32bdb36
format
pieh 674107a
Merge remote-tracking branch 'upstream/master' into ie11-promise
pieh 44980ae
move cache-dir back to root Gatsby dir, remove flow used in prefetche…
pieh e2e723a
cleanup package.json
pieh 72a21d9
update yarn.lock
pieh 9a5b113
run tests in gatsby/cache-dir again
pieh f300bc8
test running babel with miminimal config on cache-dir
pieh 7d6eb85
doh, I don't need out-dir at all
pieh 500886e
format .babelrc
pieh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
{ | ||
babelrc: false, | ||
presets: [ | ||
[ | ||
"@babel/preset-env", | ||
{ | ||
loose: true, | ||
modules: false, | ||
useBuiltIns: "usage", | ||
shippedProposals: true, | ||
targets: { | ||
browsers: [">0.25%", "not dead"], | ||
}, | ||
}, | ||
], | ||
[ | ||
"@babel/preset-react", | ||
{ | ||
useBuiltIns: true, | ||
pragma: "React.createElement", | ||
}, | ||
], | ||
], | ||
plugins: [ | ||
[ | ||
"@babel/plugin-proposal-class-properties", | ||
{ | ||
loose: true, | ||
}, | ||
], | ||
"@babel/plugin-syntax-dynamic-import", | ||
[ | ||
"@babel/plugin-transform-runtime", | ||
{ | ||
helpers: true, | ||
regenerator: true, | ||
polyfill: false, | ||
}, | ||
], | ||
], | ||
} |
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
const path = require(`path`) | ||
const child = require(`child_process`) | ||
|
||
it(`Builds cache-dir with minimal config`, done => { | ||
const args = [ | ||
require.resolve(`@babel/cli/bin/babel.js`), | ||
path.join(__dirname, `..`), | ||
`--config-file`, | ||
path.join(__dirname, `.babelrc`), | ||
] | ||
|
||
const spawn = child.spawn(process.execPath, args) | ||
|
||
let stderr = `` | ||
let stdout = `` | ||
|
||
spawn.stderr.on(`data`, function (chunk) { | ||
stderr += chunk | ||
}) | ||
|
||
spawn.stdout.on(`data`, function (chunk) { | ||
stdout += chunk | ||
}) | ||
|
||
spawn.on(`close`, function () { | ||
expect(stderr).toEqual(``) | ||
expect(stdout).not.toEqual(``) | ||
done() | ||
}) | ||
}, 30000) |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
8 changes: 1 addition & 7 deletions
8
packages/gatsby/src/cache-dir/prefetcher.js → packages/gatsby/cache-dir/prefetcher.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why revert this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I don't need to revert this, I thought this needed something like
transform-optional-chaining
plugin. I'll re-check it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, so after reverting and running my WIP test ( pieh/gatsby@9a5b113...pieh:ie11-promise-test ) for this:
This was fine previously because I was applying same babel config used to build packages for
cache-dir
(which includes@babel/plugin-proposal-optional-chaining
)