Enforce a starting and trailing slash on page urls #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been a common source of problem for users, and I think gatsby can solve it automatically by enforcing these paths to fit a certain criteria. This change removes the invariant and opts to fix the path automatically removing some of the user headache. It also enforces a trailing slash for our current react-router setup.
|
I really like this. Don't make users do something software can do. I'll review more thoroughly in a few days and release 👍 |
AlexGuz23
pushed a commit
to AlexGuz23/lumen
that referenced
this pull request
Nov 3, 2022
gatsby@0.12.5 enforces trailing slashes gatsbyjs/gatsby#378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been a common source of problem for users, and I think gatsby
can solve it automatically by enforcing these paths to fit a certain
criteria.
This change removes the invariant and opts to fix the path
automatically removing some of the user headache.
Basically, when a user provides a path in the frontmatter, it should
always work. Slashes are prepended and appended automatically
where necessary.
Fixes #364