fix(gatsby): Proxy non-200 HTTP responses #36590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
2 tasks
LekoArts
added
topic: core
LekoArts
changed the title
|
Hi, thanks for the PR! Linting is complaining about two things: 564:21 error Replace `response·=·err.response` with `(response·=·err.response)` prettier/prettier
564:21 error Expected a conditional expression and instead saw an assignment no-cond-assignAnd I agree that this line here is incorrect: if (response = err.response) {You shouldn't do an assignment inside this expression. I think you just need to change the other line to res.end(error.response.rawBody)Please try that out |
LekoArts
added
the
status: awaiting author response
jsalvata
force-pushed
the
jsalvata-patch-proxy-http-errors
branch
from
f5c76b2 to
c26b508
Compare
Transfer errors responses from the proxied server, including the status code, to the client. Fixes gatsbyjs#36589, aka gatsbyjs#34244, aka gatsbyjs#33333.
jsalvata
force-pushed
the
jsalvata-patch-proxy-http-errors
branch
from
c26b508 to
d576230
Compare
|
Sorry I can't find time to work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transfer errors responses from the proxied server, including the status code, to the client.
Credit for the solution to dangkyokhoang, who provided it here.
Description
Documentation
Related Issues
Fixes #36589, aka #34244, aka #33333.