feat(gatsby): split up head & page component loading #36545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
changed the title
wardpeet
force-pushed
the
feat/partial-hydration-head
branch
from
faeb9c4
to
da03ff7
Compare
wardpeet
force-pushed
the
feat/partial-hydration-head
branch
from
da03ff7
to
d9f4619
Compare
pieh
reviewed
Sep 6, 2022
| const loadComponent = chunkName => { | ||
| if (!asyncRequires.components[chunkName]) { | ||
| const loadComponent = (chunkName, exportType = `components`) => { | ||
| if (!global.hasPartialHydration) { |
There was a problem hiding this comment.
is global.hasPartialHydration being set somewhere? I don't see it anywhere in existing code in master (yet)
There was a problem hiding this comment.
This will be available with partialHydration #36485
LekoArts
added
topic: core
tyhopp
approved these changes
Sep 7, 2022
This was referenced Sep 13, 2022
This was referenced Sep 13, 2022
This was referenced Sep 13, 2022
This was referenced Sep 13, 2022
This was referenced Sep 14, 2022
This was referenced Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow our production loader to load head & page component separately