Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby): allow deduplicating head elements on id #36138

Merged
merged 9 commits into from
Jul 18, 2022
+193 −3
Merged

feat(gatsby): allow deduplicating head elements on id #36138

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5770973
feat: deduplicate head elements on id attrbibute in browser
pieh Jul 14, 2022
1a327d5
feat: deduplicate head elements on id attrbibute in html gen
pieh Jul 14, 2022
a8c015a
page with head deduplication
pieh Jul 15, 2022
2963da8
add test
pieh Jul 15, 2022
3157d10
update comments to match current code
pieh Jul 15, 2022
1a6c5c5
Update e2e-tests/development-runtime/cypress/integration/head-functio…
pieh Jul 15, 2022
83ec61d
Update e2e-tests/development-runtime/cypress/integration/head-functio…
marvinjude Jul 15, 2022
a6a7820
add test case to e2e-production
pieh Jul 15, 2022
35f358d
add test case to head integration tests
pieh Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test
@pieh
pieh committed Jul 15, 2022
commit 2963da8c52d34bac6d27d3941641a421a45de364
19 changes: 19 additions & 0 deletions e2e-tests/development-runtime/cypress/integration/head-function-export/deduplication.js
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import headFunctionExportSharedData from "../../../shared-data/head-function-export.js"

it(`Head function export receive correct props`, () => {
cy.visit(headFunctionExportSharedData.page.deduplication).waitForRouteChange()

// icon has id and should be deduplicated
cy.get(`link[rel=deduplication]`).should("have.length", 1)
// last icon should win
cy.get(`link[rel=deduplication]`).should("have.attr", "href", "/bar")
// we should preserve id
cy.get(`link[rel=deduplication]`).should(
"have.attr",
"id",
"deduplication-test"
)

// alternate links are not using id, so should have multiple instances
cy.get(`link[rel=alternate]`).should("have.length", 2)
})
1 change: 1 addition & 0 deletions e2e-tests/development-runtime/shared-data/head-function-export.js
View file
Original file line number Diff line number Diff line change
@@ -11,6 +11,7 @@ const page = {
ssr: `${path}/ssr/`,
invalidElements: `${path}/invalid-elements/`,
fsRouteApi: `${path}/fs-route-api/`,
deduplication: `${path}/deduplication/`,
}

const data = {
12 changes: 2 additions & 10 deletions e2e-tests/development-runtime/src/pages/head-function-export/deduplication.js
View file
Original file line number Diff line number Diff line change
@@ -13,11 +13,7 @@ export default function HeadFunctionExportBasic() {
function SEO({ children }) {
return (
<>
<link
id="icon"
rel="icon"
href="data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 100 100'><text y='0.9em' font-size='90'>👤</text></svg>"
/>
<link rel="deduplication" id="deduplication-test" href="/foo" />
<link
rel="alternate"
type="application/atom+xml"
@@ -32,11 +28,7 @@ function SEO({ children }) {
export function Head() {
return (
<SEO>
<link
id="icon"
rel="icon"
href="data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 100 100'><text y='0.9em' font-size='90'>🔥</text></svg>"
/>
<link rel="deduplication" id="deduplication-test" href="/bar" />
<link rel="alternate" hrefLang="de-DE" href="/de/" />
</SEO>
)