chore(gatsby): Move memory benchmark to generic benchmark, add support for develop and custom site #35703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
imjoshin
commented
May 23, 2022
| } | ||
| } | ||
|
|
||
| async function build(dockerExec) { |
There was a problem hiding this comment.
The major change in this file was splitting out build and adding a develop option.
imjoshin
added
topic: benchmarks
pieh
approved these changes
Jun 29, 2022
imjoshin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the
memorybenchmark to be called thedocker-runnerbenchmark. There is added support for adevelopcommand, asiteparameter to mount a custom site repo, as well as future work for cold/warm builds. Thetest-suitecommand does not support these yet.Documentation
Markdown updated.