Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Run Unit Tests on Node 16 and 18 #35622

Merged
merged 12 commits into from
May 31, 2022
Merged

chore: Run Unit Tests on Node 16 and 18 #35622

merged 12 commits into from
May 31, 2022

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented May 10, 2022

Description

We should run on more than Node 14.15.0 as we'll move to >=16 later this year anyways. And we recently had some issues with Node 18, so we should also run tests again that.

This PR also improves the error message for Parcel (adding the original message) that was uncovered by swallowed errors in CI when lmdb didn't have the node 18 binaries.

Also mocking trackError in tests so that it doesn't fail on that either (as a red herring).

Unblocks: #35621

[ch50968]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 10, 2022
@LekoArts LekoArts added topic: automation Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 10, 2022
@LekoArts
Copy link
Contributor Author

LekoArts commented May 23, 2022

The PR is currently failing due to parcel-bundler/parcel#8055 - we use Parcel 2.5.0 which uses a @parcel/cache version with older LMDB version (that is not compatible with Node 18).

@LekoArts LekoArts merged commit d22a86e into master May 31, 2022
@LekoArts LekoArts deleted the node-18-tests branch May 31, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: automation Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants