feat(gatsby-plugin-page-creator): Fix gatsby plugin page creator v4 #33120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
DanielSLew
changed the title
DanielSLew
added
gatsby 4
and removed
status: triage needed
DanielSLew
changed the title
wardpeet
reviewed
Sep 9, 2021
Contributor
wardpeet
left a comment
wardpeet
left a comment
There was a problem hiding this comment.
One small remark. I need to test it to make sure but looks good!
Co-authored-by: Ward Peeters <ward@coding-tech.com>
This was referenced Jun 19, 2022
This was referenced Jun 19, 2022
This was referenced Jun 19, 2022
This was referenced Jan 31, 2023
This was referenced Jan 31, 2023
This was referenced Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to unblock the gatsby-starter-shopify from being migrated to Gatsby v4 we needed to fix the
gatsbyPathresolver. This resolver relies on extensions from the program, but this program wasn't getting fully set in the workers.We also needed to use
onPluginInitwhen compatible with the Gatsby version.Documentation
Related Issues