fix(gatsby): fix nesting of tracing spans + add docs for OpenTelemetry #33098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
KyleAMathews
added
type: bug
wardpeet
reviewed
Sep 9, 2021
Contributor
wardpeet
left a comment
wardpeet
left a comment
There was a problem hiding this comment.
Nice! 1 small comment about windows
Co-authored-by: Ward Peeters <ward@coding-tech.com>
wardpeet
added
the
bot: merge on green
wardpeet
approved these changes
Sep 9, 2021
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
gatsbyjs#33098) * nest preprocess source under extract queries activity * Add spans for ast parsing activities * Nest onPostBuild api call under activity * Nest all steps to build html renderer under the activity * Trace persisiting the cache to disk * Revert anything that's not a bug fix * Add docs for using OpenTelemetry with Honeycomb * clarify instructions * type * Update docs/docs/performance-tracing.md Co-authored-by: Ward Peeters <ward@coding-tech.com> Co-authored-by: Ward Peeters <ward@coding-tech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix spans that don't nest correctly.
Also OpenTracing is now merged into a new project called OpenTelemetry with wide support among vendors. This PR adds an example of how to make Gatsby's tracing work with this new standard.