Break variants into separate operation #32027
Conversation
gatsbot
bot
added
the
status: triage needed
packages/gatsby-source-shopify/src/query-builders/product-variants-query.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
We have a problem with the test configuration where Jest thinks that fixtures.ts is a test file and complains that there are no test cases in it. We've tried to modify the jest.config.js at the root but we can't get it to ignore this file. We've tried adding the exact path, e.g.
testPathIgnorePatterns: [
`<rootDir>/packages/gatsby-src-shopify/__tests__/fixtures.ts`,
And we've also tried moving fixtures.ts to __tests__/fixtures/index.ts to try and match the __tests__/fixtures pattern that's already there. @wardpeet any ideas on this one?
...which seems to only be an issue locally, by the way. |
sslotsky
force-pushed
the
sslotsky/ch32892
branch
from
db830a1 to
003801d
Compare
| const objectsToBuild = objects.filter(obj => { | ||
| const [, remoteType] = obj.id.match(idPattern) || [] | ||
|
|
||
| return remoteType !== `Product` | ||
| }) |
There was a problem hiding this comment.
Do we have to check if it's not a Product because we can't query for product variants directly and the new Productvariant query query's for products and product variants?
There was a problem hiding this comment.
No and yes.
We can query for variants at the top level, but I found that it didn't work quite right for incremental builds. It seems that when you add a variant, querying for products that are updated_at >= last_build_time pulls them back, but when you query for variants there's no created_at filter, and updated_at >= last_build_time doesn't pull it back.
So because of that, I wrapped our new variants query in a products query that takes the same filters as the main products query does, and now we get back all the correct records. But as a result, we get all these Product records in the results that we don't need because we already created nodes for them.
I suspect that merging this PR might mean that cold builds are a little bit slower. Hopefully not much. But without doing this, we won't be able to add presentmentPrices without removing something else, so I think we have to.
There was a problem hiding this comment.
Great, that's kind of what I figured the tradeoff would be, thanks for the explanation.
LekoArts
removed
the
status: triage needed
Description
Breaking product variants into a separate operation so that presentment prices can be added.
Shopify's bulk API has a limit on the number of connections that can be requested in a single query, so in order to support presentmentPrices requested by community members, we need to pull variants out into a separate operation.
Documentation
Related Issues
https://app.clubhouse.io/gatsbyjs/story/32892/move-product-variants-into-a-separate-operation
https://github.com/gatsbyjs/gatsby-source-shopify/issues/161