fix(gatsby): fix PNP resolving from the .cache folder #31732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
added
type: maintenance
pieh
reviewed
Jun 2, 2021
pieh
reviewed
Jun 2, 2021
pieh
reviewed
Jun 2, 2021
Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
3 tasks
merceyz
reviewed
Jun 8, 2021
Comment on lines
+21
to
+23
| if (!(process.versions as ProcessWithPNP).pnp) { | ||
| return | ||
| } |
There was a problem hiding this comment.
Sorry if I'm missing some context here but shouldn't it always do this regardless if PnP is enabled or not? Otherwise it's relying on hoisting quite a lot - https://yarnpkg.com/advanced/rulebook#packages-should-only-ever-require-what-they-formally-list-in-their-dependencies
There was a problem hiding this comment.
It should but it could be a subtle breaking change for some so I made sure to only fix it for pnp in v3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an extra resolver to route dependencies used in the .cache folder from "gatsby" package to actually route properly through PNP.
Related Issues
Fixes #30114 #19316
[ch32208]