Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-remark-images): Add decoding prop to img elements #31558

Merged

Conversation

viralganatra
Copy link
Contributor

Description

This PR follows on from #17941 and #16005.

This adds the decoding prop to img elements that are created by the gatsby-remark-images package, setting the default value to async.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 24, 2021
@viralganatra viralganatra changed the title Add decoding prop to gatsby-remark-images img element feat(gatsby-remark-images): Add decoding prop to img elements May 24, 2021
@viralganatra viralganatra force-pushed the gatsby-remark-images-image-decoding branch from 472f2f9 to 3d4d262 Compare May 24, 2021 17:27
@TylerBarnes TylerBarnes added status: needs core review Currently awaiting review from Core team member topic: media Related to gatsby-plugin-image, or general image/media processing topics topic: remark/mdx Related to Markdown, remark & MDX ecosystem and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 28, 2021
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) thanks!

@wardpeet wardpeet merged commit d45e4fb into gatsbyjs:master Jun 2, 2021
@viralganatra viralganatra deleted the gatsby-remark-images-image-decoding branch June 5, 2021 14:20
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs core review Currently awaiting review from Core team member topic: media Related to gatsby-plugin-image, or general image/media processing topics topic: remark/mdx Related to Markdown, remark & MDX ecosystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants