-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-plugin-gatsby-cloud): enable preview status indicator and tooltip #31347
Conversation
31e8bb3
to
7ebcdc6
Compare
05d8238
to
1b8445e
Compare
9a3c678
to
60a965a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some small remarks.
Do we still need all the svg files listed in the project?
For example packages/gatsby-plugin-gatsby-cloud/src/assets/successIcon.svg
packages/gatsby-plugin-gatsby-cloud/src/components/LinkIndicatorButton.js
Show resolved
Hide resolved
packages/gatsby-plugin-gatsby-cloud/src/components/LinkIndicatorButton.js
Show resolved
Hide resolved
packages/gatsby-plugin-gatsby-cloud/src/components/LinkIndicatorButton.js
Outdated
Show resolved
Hide resolved
packages/gatsby-plugin-gatsby-cloud/src/components/GatsbyIndicatorButton.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a small follow up but looks great
The new update looks nice. However, the inclusion of the I might be completely wrong here and I would love for your thoughts about it. Thanks again for your help |
This was addressed in a follow-up and was shipped with the release: #31506 |
Hey @LekoArts Thank you for the quick reply! I opened an issue, #31597, which compares the bundle sizes between versions Do I have to explicitly opt out of using the indicator? Again, thanks for you help with this matter! |
Second iteration of the preview indicator.
See video of design/usage here:
https://user-images.githubusercontent.com/51924260/118557212-de414780-b732-11eb-8ede-3cbfa5518941.mov
The indicator now features 3 buttons