Skip to content

fix(gatsby): webpack warnings are no longer in object format by default #30801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2021
Merged

fix(gatsby): webpack warnings are no longer in object format by default #30801

merged 2 commits into from
Apr 12, 2021

Conversation

KyleAMathews
Copy link
Contributor

@KyleAMathews KyleAMathews commented Apr 10, 2021 •
edited
Loading

Fixes #30780

Related: facebook/create-react-app#9943

You can use a canary version of Gatsby with this fix by installing gatsby@webpack-split-fix

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 10, 2021
KyleAMathews
KyleAMathews commented Apr 10, 2021
View reviewed changes
packages/gatsby/src/commands/build.ts

if (stats.hasWarnings()) {
reportWebpackWarnings(stats.compilation.warnings, report)
const rawMessages = stats.toJson({ moduleTrace: false })
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this restores the object format from webpack 4

@KyleAMathews
Copy link
Contributor Author

Hmmm Typescript problems sigh

kamit-transient added a commit to kamit-transient/temp_gatsby_fix that referenced this pull request Apr 10, 2021
@kamit-transient
this contains PR gatsbyjs/gatsby#30801
05794dc
@vladar vladar added topic: webpack/babel Webpack or babel and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Apr 11, 2021
vladar
vladar approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quick, thank you! 🚢

@vladar vladar merged commit 33415c8 into master Apr 12, 2021
@vladar vladar deleted the warnings-to-json branch April 12, 2021 17:12
@gatsbybot gatsbybot mentioned this pull request Apr 13, 2021
Merged
vladar pushed a commit that referenced this pull request Apr 13, 2021
@KyleAMathews @vladar
fix(gatsby): webpack warnings are no longer in object format by defau…
d0edb71 
…lt (#30801)

* fix(gatsby): webpack warnings are no longer in object format by default

* Fix (maybe) Typescript errors

(cherry picked from commit 33415c8)
vladar pushed a commit that referenced this pull request Apr 13, 2021
@KyleAMathews
fix(gatsby): webpack warnings are no longer in object format by defau…
0b99d00 
…lt (#30801) (#30853)

* fix(gatsby): webpack warnings are no longer in object format by default

* Fix (maybe) Typescript errors

(cherry picked from commit 33415c8)

Co-authored-by: Kyle Mathews <mathews.kyle@gmail.com>
This was referenced Apr 13, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 28, 2023
Open
Open
Open
Open
@ajesse11x ajesse11x mentioned this pull request Nov 29, 2023
Open
This was referenced Nov 29, 2023
Open
Open
Open
Open
This was referenced Nov 29, 2023
Open
Open
This was referenced Nov 29, 2023
Open
Open
@ajesse11x ajesse11x mentioned this pull request Nov 29, 2023
Open
This was referenced Nov 29, 2023
Open
Open
@ajesse11x ajesse11x mentioned this pull request Nov 29, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Nov 29, 2023
Open
This was referenced Nov 29, 2023
Open
Open
This was referenced Nov 29, 2023
Open
Open
Open
Open
This was referenced Nov 29, 2023
Open
Open
@kaocher82 kaocher82 mentioned this pull request Nov 30, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Dec 1, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request May 13, 2024
Open
@Rutam21 Rutam21 mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@vladar vladar vladar approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
topic: webpack/babel Webpack or babel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot read property 'split' of undefined
2 participants
@KyleAMathews @vladar