Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-plugin-functions): Add the ability to run functions locally and on Gatsby Cloud #30192

Merged
merged 76 commits into from
Apr 16, 2021
Merged

feat(gatsby-plugin-functions): Add the ability to run functions locally and on Gatsby Cloud #30192

merged 76 commits into from
Apr 16, 2021

Conversation

sidharthachatterjee
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee commented Mar 11, 2021 •
edited by KyleAMathews
Loading

An initial implementation of Gatsby Functions. Learn more at the RFC at #27667

Post feedback at #30735

Test this by installing gatsby@functions-next & adding FUNCTIONS: true to your flags in your gatsby-config.js.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 11, 2021
@sidharthachatterjee sidharthachatterjee removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 11, 2021
@kelvindecosta
Copy link
Contributor

Can't wait to use this!

sidharthachatterjee and others added 7 commits March 12, 2021 20:32
@sidharthachatterjee
Use a parameter in express middleware and ignore extension (#30222)
3d9ecbc
Merge remote-tracking branch 'upstream/master' into feat/functions
6067919
@sidharthachatterjee
Publish 0.1.0-6
2aacbcc
@sidharthachatterjee
Set a default functions directory path (#30277)
1587dc2
@julienp
feat(functions): Add body parser
f0ab110
@abhiaiyer91 @sidharthachatterjee @wardpeet
Require files from the .cache directory so user can run es/commonjs (#…
b5324f9 
…30338)

* Require files from the .cache directory so user can run es/commonjs

* Panic on build if we get an error

* Add some logging via reporter

* logging to func

* Update packages/gatsby-plugin-functions/src/gatsby-node.ts

Co-authored-by: Ward Peeters <ward@coding-tech.com>

* Function name does not include extension

* Print a relative path to the functions directory

Co-authored-by: Sidhartha Chatterjee <me@sidharthachatterjee.com>
Co-authored-by: Ward Peeters <ward@coding-tech.com>
@sidharthachatterjee
Publish 0.1.0-7
21e1841
@sidharthachatterjee sidharthachatterjee marked this pull request as ready for review March 29, 2021 11:25
@KyleAMathews KyleAMathews requested a review from LekoArts April 15, 2021 23:26
@KyleAMathews KyleAMathews dismissed wardpeet’s stale review April 15, 2021 23:26

on vacation & requests are resolved

LekoArts
LekoArts suggested changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing we should also make sure with additional tests is how resilient our code is against names with special characters. Right now we only test the thing we are used to which is some-name.js.

What about:

  • I-Am-Capitalized.js
  • some whitespace.js
  • with-äöü-umlaut.js
  • some-àè-french.js
  • use#hashtag.js
  • some-אודות.js

This also gets relevant when we'd have src/api/endpoint/[...catch].js and people would access that with those characters

integration-tests/functions/__tests__/functions.js Show resolved Hide resolved
integration-tests/functions/src/api/i-am-typescript.ts Outdated Show resolved Hide resolved
@KyleAMathews
Copy link
Contributor

@LekoArts the hashtag one wouldn't work as it's a url fragment (which aren't sent to the server)

@KyleAMathews KyleAMathews requested a review from LekoArts April 16, 2021 12:04
@LekoArts
Copy link
Contributor

LekoArts commented Apr 16, 2021 •
edited
Loading

Gotcha. Just added it as @pieh found a weird webpack bug that occurs when people use # in their filenames 😆

@KyleAMathews
Copy link
Contributor

@pieh would find that!

LekoArts
LekoArts approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, got nothing else to add on my part. Dunno if @ascorbic wants to add anything to the .env handling?

@ascorbic
Copy link
Contributor

No, that's fine by me.

@KyleAMathews KyleAMathews merged commit 41eef2b into master Apr 16, 2021
@KyleAMathews KyleAMathews deleted the feat/functions branch April 16, 2021 16:08
@dmccraw
Copy link
Contributor

dmccraw commented Apr 16, 2021

🎉 🎉 Thanks everyone for getting this across the finish line. Huge for our Cloud Functions work!!!

@KyleAMathews
Copy link
Contributor

🎉 indeed!

Published in gatsby@next — see you over in the discussion! #30735

@LekoArts LekoArts mentioned this pull request Apr 28, 2021
Merged
@LekoArts LekoArts added the topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters) label May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleAMathews KyleAMathews KyleAMathews left review comments

@vladar vladar vladar left review comments

@ascorbic ascorbic ascorbic left review comments

@julienp julienp julienp left review comments

@jamo jamo jamo left review comments

@LekoArts LekoArts LekoArts approved these changes

@wardpeet wardpeet wardpeet left review comments

Assignees
No one assigned
Labels
topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.