Skip to content

fix(gatsby-transformer-sharp): Fix options override #29897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2021
Merged

fix(gatsby-transformer-sharp): Fix options override #29897

merged 1 commit into from
Mar 1, 2021

Conversation

laurieontech
Copy link
Contributor

Formats can be changed with gatsby-plugin-sharp options. This works for StaticImage but currently breaks for GatsbyImage because gatsby-transformer-sharp defaults it for you. Since we're already handling it inside plugin-sharp we can remove the resolver default.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 1, 2021
@laurieontech laurieontech added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 1, 2021
@laurieontech laurieontech marked this pull request as draft March 1, 2021 19:55
@laurieontech laurieontech marked this pull request as ready for review March 1, 2021 19:59
@laurieontech laurieontech merged commit 57c131d into master Mar 1, 2021
@laurieontech laurieontech deleted the try-again branch March 1, 2021 20:24
@gatsbybot gatsbybot mentioned this pull request Mar 2, 2021
Merged
vladar pushed a commit that referenced this pull request Mar 2, 2021
@vladar
will git stop being weird (#29897)
2df99ae 
(cherry picked from commit 57c131d)
vladar pushed a commit that referenced this pull request Mar 2, 2021
will git stop being weird (#29897) (#29907)
b2628da 
(cherry picked from commit 57c131d)

Co-authored-by: LB <laurie@gatsbyjs.com>
@gatsbybot gatsbybot mentioned this pull request Mar 4, 2021
Merged
pieh pushed a commit that referenced this pull request Mar 4, 2021
@pieh
will git stop being weird (#29897)
b02ca7f 
(cherry picked from commit 57c131d)
pieh pushed a commit that referenced this pull request Mar 4, 2021
will git stop being weird (#29897) (#30005)
b576211 
(cherry picked from commit 57c131d)

Co-authored-by: LB <laurie@gatsbyjs.com>
This was referenced Mar 9, 2021
Closed
Closed
Closed
Merged
Closed
Closed
@ajesse11x ajesse11x mentioned this pull request Mar 9, 2021
Open
@kaocher82 kaocher82 mentioned this pull request Mar 9, 2021
Open
This was referenced Mar 9, 2021
Open
Open
This was referenced Mar 9, 2021
Open
Open
This was referenced Mar 9, 2021
Open
Open
Open
@monizb monizb mentioned this pull request Apr 14, 2024
Open
@ajesse11x ajesse11x mentioned this pull request Apr 15, 2024
Open
@kaocher82 kaocher82 mentioned this pull request Apr 15, 2024
Open
@wizbit wizbit mentioned this pull request Apr 15, 2024
Open
@tonyg101 tonyg101 mentioned this pull request Apr 15, 2024
Open
@impactyogi impactyogi mentioned this pull request Apr 15, 2024
Open
@wizbit wizbit mentioned this pull request Apr 15, 2024
Open
This was referenced Apr 15, 2024
Open
Open
@monizb monizb mentioned this pull request Apr 29, 2024
Open
@nidhi42 nidhi42 mentioned this pull request May 14, 2024
Open
@monizb monizb mentioned this pull request May 14, 2024
Open
@ajesse11x ajesse11x mentioned this pull request May 14, 2024
Open
@kaocher82 kaocher82 mentioned this pull request May 14, 2024
Open
@saurabharch saurabharch mentioned this pull request May 14, 2024
Open
@Rutam21 Rutam21 mentioned this pull request May 16, 2024
Open
This was referenced May 16, 2024
Open
Open
@ferdi05 ferdi05 mentioned this pull request Oct 10, 2024
Open
This was referenced Oct 13, 2024
Open
Open
This was referenced Oct 15, 2024
Open
Open
This was referenced Oct 15, 2024
Open
Open
This was referenced Oct 16, 2024
Open
Open
Open
Open
@Rutam21 Rutam21 mentioned this pull request Oct 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ascorbic ascorbic ascorbic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

topic: media Related to gatsby-plugin-image, or general image/media processing topics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@laurieontech @ascorbic