Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): Fix various small DEV_SSR bugs exposed in development_runtime tests #29720

Merged
merged 13 commits into from
Mar 1, 2021
Merged

fix(gatsby): Fix various small DEV_SSR bugs exposed in development_runtime tests #29720

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
009d4f1
the dev server now returns 404s which would otherwise fail the tests
KyleAMathews Feb 23, 2021
4541305
Correctly detect if there's any SSRed HTML as ___gatsby always has th…
KyleAMathews Feb 23, 2021
b3a7113
Handle unicode paths like /안녕
KyleAMathews Feb 23, 2021
9b73a27
Properly escape paths with special characters in it
KyleAMathews Feb 23, 2021
dee3f58
Enable DEV_SSR for everyone
KyleAMathews Feb 23, 2021
83b63d0
Fix status in test
KyleAMathews Feb 23, 2021
aa651e5
Revert to 20% rollout
KyleAMathews Feb 24, 2021
1fbefd5
Merge remote-tracking branch 'origin/master' into dev-ssr-100%
KyleAMathews Feb 24, 2021
63e3f3d
revert changes for 100% rollout
KyleAMathews Feb 24, 2021
b2799f4
Merge remote-tracking branch 'origin/master' into dev-ssr-100%
KyleAMathews Feb 25, 2021
0e95ada
test this
KyleAMathews Feb 26, 2021
9368754
Merge remote-tracking branch 'origin/master' into dev-ssr-100%
KyleAMathews Feb 26, 2021
3e36529
Merge remote-tracking branch 'origin/master' into dev-ssr-100%
KyleAMathews Feb 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test this
  • Loading branch information
@KyleAMathews
KyleAMathews committed Feb 26, 2021
commit 0e95ada6391c6c3bdc827279b8e3c21f9b2920ab
5 changes: 2 additions & 3 deletions packages/gatsby/cache-dir/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,14 +121,13 @@ apiRunnerAsync(`onClientEntry`).then(() => {

const rootElement = document.getElementById(`___gatsby`)

const focusEl = document.getElementById(`gatsby-focus-wrapper`)
const renderer = apiRunner(
`replaceHydrateFunction`,
undefined,
// Client only pages have any empty body so we just do a normal
// render to avoid React complaining about hydration mis-matches.
document.getElementById(`gatsby-focus-wrapper`).children.length === 0
? ReactDOM.render
: ReactDOM.hydrate
focusEl && focusEl.children.length > 0 ? ReactDOM.hydrate : ReactDOM.render
)[0]

let dismissLoadingIndicator
Expand Down