fix(gatsby): render QoD overlay in its own root element to avoid hydration issues #29692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
reviewed
Feb 23, 2021
Contributor
wardpeet
left a comment
wardpeet
left a comment
There was a problem hiding this comment.
Still need to test but added some small nits. Code looks good
Co-authored-by: Ward Peeters <ward@coding-tech.com>
Co-authored-by: Ward Peeters <ward@coding-tech.com>
pieh
approved these changes
Feb 23, 2021
KyleAMathews
added
topic: ssr
and removed
status: triage needed
Contributor
|
This won't apply cleanly to the release branch, as you seem to have changed other things in there. Could you do a new PR against the release branch? |
Contributor
Author
|
On it 👍 |
Contributor
|
Published in |
LekoArts
added
the
topic: DX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clears way to enabling DEV_SSR for everyone.