fix(gatsby): more reliable way to use prod versions of react/react-dom #29683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
back port of #29620 to v2 Fix #28138 (comment) Set `NODE_ENV` to `production` in the child worker that does the SSR in dev.
gatsbot
bot
added
the
status: triage needed
KyleAMathews
added
topic: ssr
and removed
status: triage needed
Contributor
Author
|
Windows tests are failing on the node version used 🤔 |
Contributor
|
This seems fine, can you update snapshot (I think we already did this in master) |
Contributor
Other backport PRs also had this test failing because of that snapshot so I would say if we want to update snapshot for that branch, let's do this separately |
pieh
approved these changes
Feb 22, 2021
Contributor
Author
|
snapshot fix @ #29697 |
pieh
approved these changes
Feb 23, 2021
Contributor
|
Published in |
This was referenced Feb 25, 2021
This was referenced May 5, 2021
This was referenced Oct 31, 2022
This was referenced Dec 6, 2023
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
back port of #29620 to v2
Fix #28138 (comment)
Set
NODE_ENVtoproductionin the child worker that does the SSR in dev.