fix(gatsby-plugin-sharp): Fix defaults handling #29564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
ascorbic
added
topic: media
Contributor
laurieontech
left a comment
laurieontech
left a comment
There was a problem hiding this comment.
One question. but looks good otherwise!
| ## Options | ||
|
|
||
| - `defaults`: default values used for `gatsbyImageData` and `StaticImage` from [gatsby-plugin-image](https://www.gatsbyjs.com/plugins/gatsby-plugin-image). | ||
| Available options are: `formats`,`placeholder`,`quality`,`breakpoints`,`backgroundColor`,`tracedSVGOptions`,`blurredOptions`,`jpgOptions`,`pngOptions`,`webpOptions`,`avifOptions`. |
Contributor
Author
There was a problem hiding this comment.
I don't think it makes sense as something to be able to change defaults. I left out things that are very specific to individual images: dimensions, aspect ratio and layout
Contributor
Author
There was a problem hiding this comment.
...and transform options
laurieontech
approved these changes
Feb 18, 2021
ascorbic
added a commit
that referenced
this pull request
Feb 19, 2021
Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com> (cherry picked from commit 107926a)
ascorbic
added a commit
that referenced
this pull request
Feb 22, 2021
Contributor
Author
|
Published in |
This was referenced Feb 25, 2021
This was referenced Feb 27, 2021
This was referenced Mar 12, 2021
Closed
This was referenced Oct 31, 2022
This was referenced Dec 6, 2023
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous defaults handling didn't work with array values. This replaces the standard lodash
defaultsDeepwith a custom function that replaces rather than merges arrays. Added unit tests to verify.