Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to node 12.13 #29312

Closed
wants to merge 5 commits into from
Closed

chore: upgrade to node 12.13 #29312

wants to merge 5 commits into from

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Feb 3, 2021

Description

Upgraded all packages to node 12 and bumped all peerdeps

Using the following config in Lerna to keep minors below 1

versions.set('gatsby-admin', '0.10.0-next.0');
versions.set('gatsby-plugin-graphql-config', '0.9.0-next.0');
versions.set('gatsby-recipes', '0.11.0-next.0');
versions.set('gatsby-theme', '0.10.0-next.0');

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 3, 2021
@wardpeet wardpeet added status: needs core review Currently awaiting review from Core team member and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 3, 2021
@wardpeet wardpeet force-pushed the v3/node-12 branch 11 times, most recently from 98dedea to 0b1d75f Compare February 4, 2021 14:16
@wardpeet wardpeet force-pushed the v3/node-12 branch 2 times, most recently from 1280e5e to 66e8979 Compare February 4, 2021 21:20
vladar
vladar previously approved these changes Feb 5, 2021
@thibaudcolas
Copy link

thibaudcolas commented Apr 27, 2021

Just commenting to say I’m surprised this was marked as a chore in conventional-commits terminology, and as such this change wasn’t surfaced in the gatsby-cli CHANGELOG, where I would expect the information to be. I would have expected changing the supported Node version to be a breaking change – particularly since gatsby-cli’s recommended install method is npm install -g gatsby-cli.

For my project upgrading from Node 10 to Node 12 isn’t an immediate option, so it’s pretty important to know what version of gatsby-cli to install that will work with it.

Anyway, npm install -g gatsby-cli@2 worked for me, installing v2.19.2 of the CLI.

@wardpeet
Copy link
Contributor Author

Hey,

We bumped node 10 - 12 during a major. At least it should have 😬 Don't you get an error when doing it on a wrong ndoe version?

@thibaudcolas
Copy link

I do, but there is no mention of when the version bump happened that I could see (and the error message doesn't say either), so I resorted to trying all of the minor releases one after the other until I reached v2.

mwfrost pushed a commit to mwfrost/gatsby that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs core review Currently awaiting review from Core team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants