Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby): Remove deleteNode with ID arg #29205

Merged
merged 10 commits into from
Feb 10, 2021
Merged

feat(gatsby): Remove deleteNode with ID arg #29205

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
106c2d5
remove nodeId as arg
LekoArts Jan 26, 2021
d3cb7de
update signature, add new v4 deprecation warning, local tests pass
LekoArts Jan 27, 2021
ef41886
add test case to check for deprecation message
LekoArts Jan 27, 2021
eb17221
update existing tests
LekoArts Jan 27, 2021
2652407
update deleteNode usage in our code
LekoArts Jan 27, 2021
c0e48ae
Merge remote-tracking branch 'upstream/master' into v3/delete-node-wi…
Feb 9, 2021
75eab7e
update wordpress plugin
LekoArts Feb 9, 2021
bb5c2e8
Merge branch 'master' into v3/delete-node-with-id-argument
LekoArts Feb 10, 2021
d03f0ed
Revert "update wordpress plugin"
LekoArts Feb 10, 2021
f9dbd41
improve message
LekoArts Feb 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
improve message
  • Loading branch information
@LekoArts
LekoArts committed Feb 10, 2021
commit f9dbd41b21837e6b31ed26b6f94e07dbcbd36279
2 changes: 1 addition & 1 deletion packages/gatsby/src/db/__tests__/nodes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ describe(`nodes db tests`, () => {
)
expect(getNode(`hi`)).toBeUndefined()
const deprecationNotice =
`Calling "deleteNode" with an object containing a full node is deprecated. Please pass ` +
`Calling "deleteNode" with {node} is deprecated. Please pass ` +
`the node directly to the function: deleteNode(node) ` +
`"deleteNode" was called by tests`
expect(report.warn).toHaveBeenCalledWith(deprecationNotice)
Expand Down
2 changes: 1 addition & 1 deletion packages/gatsby/src/redux/actions/public.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ actions.deleteNode = (node: any, plugin?: Plugin) => {
// TODO(v4): Remove this deprecation warning and only allow deleteNode(node)
if (node && node.node) {
let msg =
`Calling "deleteNode" with an object containing a full node is deprecated. Please pass ` +
`Calling "deleteNode" with {node} is deprecated. Please pass ` +
`the node directly to the function: deleteNode(node)`

if (plugin && plugin.name) {
Expand Down