Skip to content

chore(telemetry): allow sharing tags in a file and read it only when things change #28953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gatsbybot merged 2 commits into from
Jan 11, 2021
Merged

chore(telemetry): allow sharing tags in a file and read it only when things change #28953

gatsbybot merged 2 commits into from
Jan 11, 2021

Conversation

@jamo
Copy link
Contributor

@jamo jamo commented Jan 9, 2021 •
edited
Loading

Allow reading telemetry data from a file

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 9, 2021
@jamo jamo force-pushed the telemetry-metadata branch from 30c21bc to 934d01b Compare January 9, 2021 20:31
@jamo jamo force-pushed the telemetry-metadata branch from 934d01b to a156328 Compare January 9, 2021 20:33
@jamo
Copy link
Contributor Author

jamo commented Jan 10, 2021

I had stale reads / edits with out the sleeps. Might be just my zfs fs but the multi-second sleep was the only way I got it to be reliable.

@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 11, 2021
@jamo
Copy link
Contributor Author

jamo commented Jan 11, 2021

This has been tested manually and is working well.

@jamo jamo added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 11, 2021
wardpeet
wardpeet approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this does but code looks fine

@gatsbybot gatsbybot merged commit 9cb8eeb into master Jan 11, 2021
@gatsbybot gatsbybot deleted the telemetry-metadata branch January 11, 2021 21:48
vladar pushed a commit that referenced this pull request Jan 12, 2021
@jamo @vladar
chore(telemetry): allow sharing tags in a file and read it only when …
1fd6655 
…things change (#28953)

* chore(telemetry): allow sharing tags in a file and read it only when
things change

* Types

(cherry picked from commit 9cb8eeb)
@gatsbybot gatsbybot mentioned this pull request Jan 12, 2021
Merged
gatsbybot pushed a commit that referenced this pull request Jan 13, 2021
@jamo
chore(telemetry): allow sharing tags in a file and read it only when …
1617c6c 
…things change (#28953) (#28992)

* chore(telemetry): allow sharing tags in a file and read it only when
things change

* Types

(cherry picked from commit 9cb8eeb)

Co-authored-by: Jarmo Isotalo <jamo@isotalo.fi>
@vladar
Copy link
Contributor

vladar commented Jan 13, 2021

Published in gatsby-telemetry@1.8.1

pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
@gatsbybot
chore(telemetry): allow sharing tags in a file and read it only when …
2a66213 
…things change (gatsbyjs#28953)

* chore(telemetry): allow sharing tags in a file and read it only when
things change

* Types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wardpeet wardpeet wardpeet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bot: merge on green Gatsbot will merge these PRs automatically when all tests passes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jamo @vladar @wardpeet @LekoArts @gatsbybot