Update plugin option schema validation code sample #28904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The testPluginOptionsSchema returns promise.
gatsbot
bot
added
the
status: triage needed
Simply007
changed the title
LekoArts
added
type: documentation
Contributor
Author
|
@LekoArts - is there anything else to do on my side? |
laurieontech
approved these changes
Jan 21, 2021
Contributor
laurieontech
left a comment
laurieontech
left a comment
There was a problem hiding this comment.
Absolutely correct. When we changed this function I must have missed these docs. Thanks for addressing!
laurieontech
added
the
bot: merge on green
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
* Update configuring-usage-with-plugin-options.md The testPluginOptionsSchema returns promise. * Add mention about Kontent implementation
This was referenced Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
testPluginOptionsSchemareturnsPromiseso that calling it should be inasyncawaitconstruct for test code sample.asyncawait: https://github.com/Kentico/kontent-gatsby-packages/blob/master/packages/gatsby-source-kontent/tests/pluginOptionsSchema.spec.tsRelated Issues
Found during implementation kontent-ai/gatsby-packages#167