fix(gatsby): move starting dev-ssr listener inside function & only init listeners once #28395
+25
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it listeners once
gatsbot
bot
added
the
status: triage needed
KyleAMathews
added
type: feature or enhancement
pieh
reviewed
Dec 1, 2020
Comment on lines
+16
to
+22
| There are 5 other flags available that you might be interested in: | ||
| - FAST_DEV · Enable all experiments aimed at improving develop server start time | ||
| - DEV_SSR · (Umbrella Issue (https://github.com/gatsbyjs/gatsby/discussions/28138)) · SSR pages on full reloads during develop. Helps you detect SSR bugs and fix them without needing to do full builds. | ||
| - QUERY_ON_DEMAND · (Umbrella Issue (https://github.com/gatsbyjs/gatsby/discussions/27620)) · Only run queries when needed instead of running all queries upfront. Speeds starting the develop server. | ||
| - ONLY_BUILDS · (Umbrella Issue (test)) · test | ||
| - YET_ANOTHER · (Umbrella Issue (test)) · test |
Contributor
There was a problem hiding this comment.
Why is this here? And why unit tests passes here without any changes to tests? did we merge something that didn't update snapshot?
pieh
approved these changes
Dec 1, 2020
Contributor
pieh
left a comment
pieh
left a comment
There was a problem hiding this comment.
This is ok (good to check if we attached listeners already or not), but the root problem to me is that we call startListener() multiple times - we should not do that in first place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The listeners were gettiing reattached on every SSR.
Also... ssr changes weren't getting compiled w/o a save. So this fixes two bugs.